Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10234)

Unified Diff: chrome/test/chromedriver/command.h

Issue 19616008: [chromedriver] Allow commands to be async. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/adb_impl.cc ('k') | chrome/test/chromedriver/commands.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/command.h
diff --git a/chrome/test/chromedriver/command.h b/chrome/test/chromedriver/command.h
index 6654694af5e14bb8bbeb6dba3394578f9c853786..e57a5f2ff0a9da08d0cc9e8e4f925693a00a4cd1 100644
--- a/chrome/test/chromedriver/command.h
+++ b/chrome/test/chromedriver/command.h
@@ -17,10 +17,14 @@ class Value;
class Status;
-typedef base::Callback<Status(
+typedef base::Callback<void(
+ const Status&,
+ scoped_ptr<base::Value>,
+ const std::string&)> CommandCallback;
+
+typedef base::Callback<void(
const base::DictionaryValue&,
const std::string&,
- scoped_ptr<base::Value>*,
- std::string*)> Command;
+ const CommandCallback&)> Command;
#endif // CHROME_TEST_CHROMEDRIVER_COMMAND_H_
« no previous file with comments | « chrome/test/chromedriver/chrome/adb_impl.cc ('k') | chrome/test/chromedriver/commands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698