Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1961133002: Update FLAC to 1.3.1 (Closed)

Created:
4 years, 7 months ago by hans
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/flac.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update FLAC to 1.3.1 This includes fixes for CVE-2014-9028 and CVE-2014-8962 (which shouldn't affect Chromium since we only use FLAC for encoding). It also reduces the number of downstream patches. BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=610125 R=felt@chromium.org, tommi@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/flac/+/59c0c55a573a063d2a3fb9d1501f88a5e8f78176

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : win_utf8_io #

Patch Set 4 : rebase on a change that was never rolled in #

Patch Set 5 : fix WIN32_LEAN_AND_MEAN double #define #

Patch Set 6 : tweak LoadLibrary call to fix Windows build #

Patch Set 7 : build config tweaks for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15431 lines, -1865 lines) Patch
M AUTHORS View 2 chunks +21 lines, -4 lines 0 comments Download
M BUILD.gn View 1 2 3 4 5 6 3 chunks +24 lines, -1 line 0 comments Download
M COPYING.GPL View 11 chunks +21 lines, -22 lines 0 comments Download
M COPYING.Xiph View 1 chunk +2 lines, -1 line 0 comments Download
M README View 9 chunks +41 lines, -41 lines 0 comments Download
M README.chromium View 1 2 3 4 5 1 chunk +9 lines, -11 lines 0 comments Download
M flac.gyp View 1 2 3 4 5 6 3 chunks +30 lines, -1 line 0 comments Download
M include/FLAC/all.h View 2 chunks +3 lines, -2 lines 0 comments Download
M include/FLAC/assert.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/FLAC/callback.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/FLAC/export.h View 2 chunks +15 lines, -9 lines 0 comments Download
M include/FLAC/format.h View 3 chunks +17 lines, -2 lines 0 comments Download
M include/FLAC/metadata.h View 3 chunks +4 lines, -3 lines 0 comments Download
M include/FLAC/ordinals.h View 2 chunks +20 lines, -14 lines 0 comments Download
M include/FLAC/stream_decoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M include/FLAC/stream_encoder.h View 6 chunks +47 lines, -25 lines 0 comments Download
A include/share/compat.h View 1 chunk +201 lines, -0 lines 0 comments Download
A + include/share/endswap.h View 2 chunks +38 lines, -40 lines 0 comments Download
A + include/share/private.h View 2 chunks +12 lines, -12 lines 0 comments Download
A + include/share/win_utf8_io.h View 1 2 2 chunks +28 lines, -47 lines 0 comments Download
M src/libFLAC/bitmath.c View 2 chunks +3 lines, -43 lines 0 comments Download
M src/libFLAC/bitreader.c View 22 chunks +158 lines, -465 lines 0 comments Download
M src/libFLAC/bitwriter.c View 18 chunks +48 lines, -94 lines 0 comments Download
M src/libFLAC/cpu.c View 5 chunks +335 lines, -266 lines 0 comments Download
M src/libFLAC/crc.c View 5 chunks +7 lines, -6 lines 0 comments Download
M src/libFLAC/fixed.c View 5 chunks +11 lines, -27 lines 0 comments Download
A src/libFLAC/fixed_intrin_sse2.c View 1 chunk +253 lines, -0 lines 0 comments Download
A src/libFLAC/fixed_intrin_ssse3.c View 1 chunk +241 lines, -0 lines 0 comments Download
M src/libFLAC/float.c View 3 chunks +5 lines, -11 lines 0 comments Download
M src/libFLAC/format.c View 7 chunks +21 lines, -29 lines 0 comments Download
A src/libFLAC/ia32/cpu_asm.nasm View 1 chunk +98 lines, -0 lines 0 comments Download
A src/libFLAC/ia32/fixed_asm.nasm View 1 chunk +309 lines, -0 lines 0 comments Download
A src/libFLAC/ia32/lpc_asm.nasm View 1 chunk +2049 lines, -0 lines 0 comments Download
A src/libFLAC/ia32/nasm.h View 1 chunk +85 lines, -0 lines 0 comments Download
M src/libFLAC/include/private/all.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libFLAC/include/private/bitmath.h View 2 chunks +147 lines, -3 lines 0 comments Download
M src/libFLAC/include/private/bitreader.h View 3 chunks +3 lines, -11 lines 0 comments Download
M src/libFLAC/include/private/bitwriter.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libFLAC/include/private/cpu.h View 2 chunks +101 lines, -21 lines 0 comments Download
M src/libFLAC/include/private/crc.h View 3 chunks +7 lines, -7 lines 0 comments Download
M src/libFLAC/include/private/fixed.h View 3 chunks +15 lines, -5 lines 0 comments Download
M src/libFLAC/include/private/float.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libFLAC/include/private/format.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libFLAC/include/private/lpc.h View 5 chunks +38 lines, -6 lines 0 comments Download
A + src/libFLAC/include/private/macros.h View 2 chunks +35 lines, -21 lines 0 comments Download
M src/libFLAC/include/private/md5.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/libFLAC/include/private/memory.h View 2 chunks +8 lines, -6 lines 0 comments Download
M src/libFLAC/include/private/metadata.h View 1 chunk +2 lines, -1 line 0 comments Download
A + src/libFLAC/include/private/stream_encoder.h View 2 chunks +24 lines, -45 lines 0 comments Download
M src/libFLAC/include/private/stream_encoder_framing.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libFLAC/include/private/window.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/libFLAC/include/protected/all.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/libFLAC/include/protected/stream_decoder.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/libFLAC/include/protected/stream_encoder.h View 3 chunks +9 lines, -1 line 0 comments Download
M src/libFLAC/lpc.c View 18 chunks +48 lines, -68 lines 0 comments Download
A src/libFLAC/lpc_intrin_avx2.c View 1 chunk +1120 lines, -0 lines 0 comments Download
A src/libFLAC/lpc_intrin_sse.c View 1 chunk +451 lines, -0 lines 0 comments Download
A src/libFLAC/lpc_intrin_sse2.c View 1 chunk +1088 lines, -0 lines 0 comments Download
A src/libFLAC/lpc_intrin_sse41.c View 1 chunk +1312 lines, -0 lines 0 comments Download
M src/libFLAC/md5.c View 8 chunks +205 lines, -111 lines 0 comments Download
M src/libFLAC/memory.c View 14 chunks +33 lines, -36 lines 0 comments Download
A src/libFLAC/metadata_iterators.c View 1 chunk +3402 lines, -0 lines 0 comments Download
A src/libFLAC/metadata_object.c View 1 chunk +1824 lines, -0 lines 0 comments Download
M src/libFLAC/stream_decoder.c View 43 chunks +159 lines, -160 lines 0 comments Download
M src/libFLAC/stream_encoder.c View 57 chunks +312 lines, -149 lines 0 comments Download
M src/libFLAC/stream_encoder_framing.c View 5 chunks +9 lines, -13 lines 0 comments Download
A src/libFLAC/stream_encoder_intrin_avx2.c View 1 chunk +142 lines, -0 lines 0 comments Download
A src/libFLAC/stream_encoder_intrin_sse2.c View 1 chunk +159 lines, -0 lines 0 comments Download
A src/libFLAC/stream_encoder_intrin_ssse3.c View 1 chunk +147 lines, -0 lines 0 comments Download
M src/libFLAC/window.c View 6 chunks +70 lines, -13 lines 0 comments Download
A src/share/win_utf8_io/win_utf8_io.c View 1 2 3 4 5 1 chunk +373 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hans
tweak LoadLibrary call to fix Windows build
4 years, 7 months ago (2016-05-09 20:20:19 UTC) #1
hans
build config tweaks for Windows
4 years, 7 months ago (2016-05-09 20:46:48 UTC) #2
hans
Please take a look.
4 years, 7 months ago (2016-05-09 21:54:26 UTC) #5
tommi (sloooow) - chröme
lgtm
4 years, 7 months ago (2016-05-10 08:10:49 UTC) #6
felt
thanks for doing this. lgtm.
4 years, 7 months ago (2016-05-10 14:32:19 UTC) #7
hans
4 years, 7 months ago (2016-05-10 16:21:43 UTC) #9
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
59c0c55a573a063d2a3fb9d1501f88a5e8f78176 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698