Choose the best offline page when given an online URL.

Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534
Committed: https://crrev.com/7e23e9807b3e086641c417c1325843238054ba94
Cr-Commit-Position: refs/heads/master@{#392748}

[dewittj, 2016-05-10 17:16:02]

Patchset #1 (id:1) has been deleted

[dewittj, 2016-05-10 17:17:10]

Description was changed from

==========
Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534
==========

to

==========
Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534
==========

[dewittj, 2016-05-10 17:17:10]

dewittj@chromium.org changed reviewers:
+ fgorski@chromium.org

[dewittj, 2016-05-10 17:17:17]

ptal

[fgorski, 2016-05-10 20:52:54]

lgtm with nits.

https://codereview.chromium.org/1959393002/diff/100001/components/offline_pag...
File components/offline_pages/offline_page_model.h (right):

https://codereview.chromium.org/1959393002/diff/100001/components/offline_pag...
components/offline_pages/offline_page_model.h:247: // page will be preferred
over an older one.  This API function does not
nit: Be consistent with usage of double space after period. See above after
"any."

https://codereview.chromium.org/1959393002/diff/100001/components/offline_pag...
components/offline_pages/offline_page_model.h:255: // not found.  The best page
is chosen based on creation date; a more recently
Simply:
See |GetBestPAge..| for selection of best page.

[dewittj, 2016-05-10 21:08:01]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2016-05-10 21:08:02]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/1959393002/#ps120001
(title: "Address nits.")

[commit-bot: I haz the power, 2016-05-10 21:10:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1959393002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1959393002/120001

[commit-bot: I haz the power, 2016-05-10 22:29:06]

Description was changed from

==========
Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534
==========

to

==========
Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534
==========

[commit-bot: I haz the power, 2016-05-10 22:29:07]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-05-10 22:31:17]

Description was changed from

==========
Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534
==========

to

==========
Choose the best offline page when given an online URL.

Current strategy is to pick the most recent page that matches the URL.

BUG=610534

Committed: https://crrev.com/7e23e9807b3e086641c417c1325843238054ba94
Cr-Commit-Position: refs/heads/master@{#392748}
==========

[commit-bot: I haz the power, 2016-05-10 22:31:17]

Patchset 6 (id:??) landed as
https://crrev.com/7e23e9807b3e086641c417c1325843238054ba94
Cr-Commit-Position: refs/heads/master@{#392748}

[dewittj, 2016-05-11 15:57:25]

https://codereview.chromium.org/1959393002/diff/100001/components/offline_pag...
File components/offline_pages/offline_page_model.h (right):

https://codereview.chromium.org/1959393002/diff/100001/components/offline_pag...
components/offline_pages/offline_page_model.h:247: // page will be preferred
over an older one.  This API function does not
On 2016/05/10 20:52:53, fgorski wrote:
> nit: Be consistent with usage of double space after period. See above after
> "any."

Done.

https://codereview.chromium.org/1959393002/diff/100001/components/offline_pag...
components/offline_pages/offline_page_model.h:255: // not found.  The best page
is chosen based on creation date; a more recently
On 2016/05/10 20:52:53, fgorski wrote:
> Simply:
> See |GetBestPAge..| for selection of best page.

Done.