Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2338)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java

Issue 1959393002: Choose the best offline page when given an online URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
index 401385217edbb59036ba97839b06214b9b97320e..e15e901b282ecccb34cdc1daedcf31757850d780 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
@@ -325,7 +325,7 @@ public class OfflinePageBridge {
// TODO(http://crbug.com/589526) This native API returns only one item, but in the
// future will return a list.
OfflinePageItem item =
- nativeGetPageByOnlineURL(mNativeOfflinePageBridge, onlineUrl);
+ nativeGetBestPageForOnlineURL(mNativeOfflinePageBridge, onlineUrl);
if (item != null) {
result.add(item);
}
@@ -626,7 +626,7 @@ public class OfflinePageBridge {
@VisibleForTesting
native OfflinePageItem nativeGetPageByOfflineId(long nativeOfflinePageBridge, long offlineId);
- private native OfflinePageItem nativeGetPageByOnlineURL(
+ private native OfflinePageItem nativeGetBestPageForOnlineURL(
long nativeOfflinePageBridge, String onlineURL);
private native OfflinePageItem nativeGetPageByOfflineUrl(
long nativeOfflinePageBridge, String offlineUrl);
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_bridge.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698