Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2284)

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils.cc

Issue 1959393002: Choose the best offline page when given an online URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nits. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_utils.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_utils.cc b/chrome/browser/android/offline_pages/offline_page_utils.cc
index e82041dd9fe4459bc98a5dcec1e50222c56a3dd3..c15d2ba3079c60ba7137be12538b3ef6cb65a65a 100644
--- a/chrome/browser/android/offline_pages/offline_page_utils.cc
+++ b/chrome/browser/android/offline_pages/offline_page_utils.cc
@@ -19,7 +19,7 @@ namespace offline_pages {
namespace {
// Returns an offline page originated from the |online_url|.
-const OfflinePageItem* GetOfflinePageForOnlineURL(
+const OfflinePageItem* MaybeGetBestOfflinePageForOnlineURL(
content::BrowserContext* browser_context,
const GURL& online_url) {
DCHECK(browser_context);
@@ -32,7 +32,7 @@ const OfflinePageItem* GetOfflinePageForOnlineURL(
if (!offline_page_model)
return nullptr;
- return offline_page_model->MaybeGetPageByOnlineURL(online_url);
+ return offline_page_model->MaybeGetBestPageForOnlineURL(online_url);
}
// Returns an offline page that is stored as the |offline_url|.
@@ -74,7 +74,7 @@ GURL OfflinePageUtils::GetOfflineURLForOnlineURL(
content::BrowserContext* browser_context,
const GURL& online_url) {
const OfflinePageItem* offline_page =
- GetOfflinePageForOnlineURL(browser_context, online_url);
+ MaybeGetBestOfflinePageForOnlineURL(browser_context, online_url);
if (!offline_page)
return GURL();
@@ -124,7 +124,7 @@ bool OfflinePageUtils::HasOfflinePageForOnlineURL(
content::BrowserContext* browser_context,
const GURL& online_url) {
const OfflinePageItem* offline_page =
- GetOfflinePageForOnlineURL(browser_context, online_url);
+ MaybeGetBestOfflinePageForOnlineURL(browser_context, online_url);
return offline_page && !offline_page->file_path.empty();
}
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.cc ('k') | components/offline_pages/offline_page_model.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698