chrome/browser/android/offline_pages/offline_page_bridge.cc - Issue 1959393002: Choose the best offline page when given an online URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.cc

Issue 1959393002: Choose the best offline page when given an online URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nits. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_bridge.h ('k') | chrome/browser/android/offline_pages/offline_page_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_bridge.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.cc b/chrome/browser/android/offline_pages/offline_page_bridge.cc

index d98654165ae103b9ed433d48660a7b757e871dbe..ee2bd0bfd7756f312df209ec5a7c7f2112d0362b 100644

--- a/chrome/browser/android/offline_pages/offline_page_bridge.cc

+++ b/chrome/browser/android/offline_pages/offline_page_bridge.cc

@@ -266,12 +266,12 @@ ScopedJavaLocalRef<jobject> OfflinePageBridge::GetPageByOfflineId(

return CreateOfflinePageItem(env, *offline_page);

}

-ScopedJavaLocalRef<jobject> OfflinePageBridge::GetPageByOnlineURL(

+ScopedJavaLocalRef<jobject> OfflinePageBridge::GetBestPageForOnlineURL(

JNIEnv* env,

const JavaParamRef<jobject>& obj,

const JavaParamRef<jstring>& online_url) {

const OfflinePageItem* offline_page =

- offline_page_model_->MaybeGetPageByOnlineURL(

+ offline_page_model_->MaybeGetBestPageForOnlineURL(

GURL(ConvertJavaStringToUTF8(env, online_url)));

if (!offline_page)

return ScopedJavaLocalRef<jobject>();