mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl - Issue 1955123003: Mojo C++ bindings: switch the remaining callsites of the old serialization interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

Issue 1955123003: Mojo C++ bindings: switch the remaining callsites of the old serialization interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@24_union_and_others

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/tests/struct_unittest.cc ('k') | mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_definition.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

diff --git a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

index 384b36649c1d8918614d798304cf6028dcf4ddca..7aa21c440f31472b5dbc2da406c8887c0c387388 100644

--- a/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

+++ b/mojo/public/tools/bindings/generators/cpp_templates/wrapper_class_declaration.tmpl

@@ -59,16 +59,6 @@ class {{struct.name}} {

{%- endfor %}

};

-{# TODO(yzshen): Remove these wrappers of the Serializer interface. #}

-size_t GetSerializedSize_({{struct.name}}Ptr& input,

- mojo::internal::SerializationContext* context);

-void Serialize_({{struct.name}}Ptr input, mojo::internal::Buffer* buffer,

- internal::{{struct.name}}_Data** output,

- mojo::internal::SerializationContext* context);

-bool Deserialize_(internal::{{struct.name}}_Data* input,

- {{struct.name}}Ptr* output,

- mojo::internal::SerializationContext* context);

{# TODO(yzshen): Redo the Reader interface. #}

{# NOTE: Generated Reader instances are intentionally cheap to copy and devoid

of heap allocations. They should stay this way. #}