Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: mojo/public/cpp/bindings/lib/control_message_proxy.cc

Issue 1955123003: Mojo C++ bindings: switch the remaining callsites of the old serialization interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@24_union_and_others
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/public/cpp/bindings/lib/control_message_proxy.h" 5 #include "mojo/public/cpp/bindings/lib/control_message_proxy.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <utility> 9 #include <utility>
10 10
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "mojo/public/cpp/bindings/lib/message_builder.h" 12 #include "mojo/public/cpp/bindings/lib/message_builder.h"
13 #include "mojo/public/cpp/bindings/lib/serialization.h"
13 #include "mojo/public/cpp/bindings/message.h" 14 #include "mojo/public/cpp/bindings/message.h"
14 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h" 15 #include "mojo/public/interfaces/bindings/interface_control_messages.mojom.h"
15 16
16 namespace mojo { 17 namespace mojo {
17 namespace internal { 18 namespace internal {
18 19
19 namespace { 20 namespace {
20 21
21 using RunCallback = Callback<void(QueryVersionResultPtr)>; 22 using RunCallback = Callback<void(QueryVersionResultPtr)>;
22 23
23 class RunResponseForwardToCallback : public MessageReceiver { 24 class RunResponseForwardToCallback : public MessageReceiver {
24 public: 25 public:
25 RunResponseForwardToCallback(const RunCallback& callback) 26 RunResponseForwardToCallback(const RunCallback& callback)
26 : callback_(callback) {} 27 : callback_(callback) {}
27 bool Accept(Message* message) override; 28 bool Accept(Message* message) override;
28 29
29 private: 30 private:
30 RunCallback callback_; 31 RunCallback callback_;
31 DISALLOW_COPY_AND_ASSIGN(RunResponseForwardToCallback); 32 DISALLOW_COPY_AND_ASSIGN(RunResponseForwardToCallback);
32 }; 33 };
33 34
34 bool RunResponseForwardToCallback::Accept(Message* message) { 35 bool RunResponseForwardToCallback::Accept(Message* message) {
35 RunResponseMessageParams_Data* params = 36 RunResponseMessageParams_Data* params =
36 reinterpret_cast<RunResponseMessageParams_Data*>( 37 reinterpret_cast<RunResponseMessageParams_Data*>(
37 message->mutable_payload()); 38 message->mutable_payload());
38 params->DecodePointers(); 39 params->DecodePointers();
39 40
40 RunResponseMessageParamsPtr params_ptr; 41 RunResponseMessageParamsPtr params_ptr;
41 Deserialize_(params, &params_ptr, nullptr); 42 SerializationContext context;
43 Deserialize<RunResponseMessageParamsPtr>(params, &params_ptr, &context);
42 44
43 callback_.Run(std::move(params_ptr->query_version_result)); 45 callback_.Run(std::move(params_ptr->query_version_result));
44 return true; 46 return true;
45 } 47 }
46 48
47 void SendRunMessage(MessageReceiverWithResponder* receiver, 49 void SendRunMessage(MessageReceiverWithResponder* receiver,
48 QueryVersionPtr query_version, 50 QueryVersionPtr query_version,
49 const RunCallback& callback) { 51 const RunCallback& callback,
52 SerializationContext* context) {
50 RunMessageParamsPtr params_ptr(RunMessageParams::New()); 53 RunMessageParamsPtr params_ptr(RunMessageParams::New());
51 params_ptr->reserved0 = 16u; 54 params_ptr->reserved0 = 16u;
52 params_ptr->reserved1 = 0u; 55 params_ptr->reserved1 = 0u;
53 params_ptr->query_version = std::move(query_version); 56 params_ptr->query_version = std::move(query_version);
54 57
55 size_t size = GetSerializedSize_(params_ptr, nullptr); 58 size_t size = PrepareToSerialize<RunMessageParamsPtr>(params_ptr, context);
56 RequestMessageBuilder builder(kRunMessageId, size); 59 RequestMessageBuilder builder(kRunMessageId, size);
57 60
58 RunMessageParams_Data* params = nullptr; 61 RunMessageParams_Data* params = nullptr;
59 Serialize_(std::move(params_ptr), builder.buffer(), &params, nullptr); 62 Serialize<RunMessageParamsPtr>(params_ptr, builder.buffer(), &params,
63 context);
60 params->EncodePointers(); 64 params->EncodePointers();
61 MessageReceiver* responder = new RunResponseForwardToCallback(callback); 65 MessageReceiver* responder = new RunResponseForwardToCallback(callback);
62 if (!receiver->AcceptWithResponder(builder.message(), responder)) 66 if (!receiver->AcceptWithResponder(builder.message(), responder))
63 delete responder; 67 delete responder;
64 } 68 }
65 69
66 void SendRunOrClosePipeMessage(MessageReceiverWithResponder* receiver, 70 void SendRunOrClosePipeMessage(MessageReceiverWithResponder* receiver,
67 RequireVersionPtr require_version) { 71 RequireVersionPtr require_version,
72 SerializationContext* context) {
68 RunOrClosePipeMessageParamsPtr params_ptr(RunOrClosePipeMessageParams::New()); 73 RunOrClosePipeMessageParamsPtr params_ptr(RunOrClosePipeMessageParams::New());
69 params_ptr->reserved0 = 16u; 74 params_ptr->reserved0 = 16u;
70 params_ptr->reserved1 = 0u; 75 params_ptr->reserved1 = 0u;
71 params_ptr->require_version = std::move(require_version); 76 params_ptr->require_version = std::move(require_version);
72 77
73 size_t size = GetSerializedSize_(params_ptr, nullptr); 78 size_t size =
79 PrepareToSerialize<RunOrClosePipeMessageParamsPtr>(params_ptr, context);
74 MessageBuilder builder(kRunOrClosePipeMessageId, size); 80 MessageBuilder builder(kRunOrClosePipeMessageId, size);
75 81
76 RunOrClosePipeMessageParams_Data* params = nullptr; 82 RunOrClosePipeMessageParams_Data* params = nullptr;
77 Serialize_(std::move(params_ptr), builder.buffer(), &params, nullptr); 83 Serialize<RunOrClosePipeMessageParamsPtr>(params_ptr, builder.buffer(),
84 &params, context);
78 params->EncodePointers(); 85 params->EncodePointers();
79 bool ok = receiver->Accept(builder.message()); 86 bool ok = receiver->Accept(builder.message());
80 ALLOW_UNUSED_LOCAL(ok); 87 ALLOW_UNUSED_LOCAL(ok);
81 } 88 }
82 89
83 } // namespace 90 } // namespace
84 91
85 ControlMessageProxy::ControlMessageProxy(MessageReceiverWithResponder* receiver) 92 ControlMessageProxy::ControlMessageProxy(MessageReceiverWithResponder* receiver)
86 : receiver_(receiver) { 93 : receiver_(receiver) {
87 } 94 }
88 95
89 void ControlMessageProxy::QueryVersion( 96 void ControlMessageProxy::QueryVersion(
90 const Callback<void(uint32_t)>& callback) { 97 const Callback<void(uint32_t)>& callback) {
91 auto run_callback = [callback](QueryVersionResultPtr query_version_result) { 98 auto run_callback = [callback](QueryVersionResultPtr query_version_result) {
92 callback.Run(query_version_result->version); 99 callback.Run(query_version_result->version);
93 }; 100 };
94 SendRunMessage(receiver_, QueryVersion::New(), run_callback); 101 SendRunMessage(receiver_, QueryVersion::New(), run_callback, &context_);
95 } 102 }
96 103
97 void ControlMessageProxy::RequireVersion(uint32_t version) { 104 void ControlMessageProxy::RequireVersion(uint32_t version) {
98 RequireVersionPtr require_version(RequireVersion::New()); 105 RequireVersionPtr require_version(RequireVersion::New());
99 require_version->version = version; 106 require_version->version = version;
100 SendRunOrClosePipeMessage(receiver_, std::move(require_version)); 107 SendRunOrClosePipeMessage(receiver_, std::move(require_version), &context_);
101 } 108 }
102 109
103 } // namespace internal 110 } // namespace internal
104 } // namespace mojo 111 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/public/cpp/bindings/lib/control_message_proxy.h ('k') | mojo/public/cpp/bindings/lib/native_struct_serialization.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698