Remove handler from MessagePumpForIO::IOContext.

Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459
Committed: https://crrev.com/324a072175552e65bc65edfa679bf00f573ee0a4
Cr-Commit-Position: refs/heads/master@{#393036}

[fdoray, 2016-05-04 20:43:53]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-04 20:44:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954543002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954543002/1

[commit-bot: I haz the power, 2016-05-05 00:33:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 00:33:04]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-05-05 20:55:29]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-05 20:56:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954543002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954543002/20001

[commit-bot: I haz the power, 2016-05-05 23:34:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 23:35:00]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-05-09 21:45:16]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org, thestig@chromium.org

[fdoray, 2016-05-09 21:45:17]

Can you review this CL? Thanks.

[fdoray, 2016-05-09 21:45:56]

Description was changed from

==========
Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459
==========

to

==========
Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459
==========

[fdoray, 2016-05-09 21:45:56]

fdoray@chromium.org changed reviewers:
- gab@chromium.org, robliao@chromium.org

[Lei Zhang, 2016-05-09 22:41:31]

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
File base/message_loop/message_pump_win.cc (left):

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
base/message_loop/message_pump_win.cc:548: if (!item.has_valid_io_context ||
item.context->handler) {
So I didn't write this code and I'm only looking at it for the first time ever.
Are you saying |item.context->handler| is always initialized to be non-NULL, and
nobody sets it to NULL like in example #1 in
base/message_loop/message_pump_win.h? Thus conditional always evaluates true,
and everything else falls in place?

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
File base/message_loop/message_pump_win.cc (right):

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
base/message_loop/message_pump_win.cc:470: info.CompletionKey =
reinterpret_cast<void*>(handler);
reinterpret_cast no longer needed?

https://codereview.chromium.org/1954543002/diff/20001/ipc/ipc_channel_win.cc
File ipc/ipc_channel_win.cc (right):

https://codereview.chromium.org/1954543002/diff/20001/ipc/ipc_channel_win.cc#...
ipc/ipc_channel_win.cc:31: ChannelWin::State::State(ChannelWin* channel) :
is_pending(false) {
Do we still need the |channel| param?

[fdoray, 2016-05-10 16:33:04]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[fdoray, 2016-05-10 16:33:17]

thestig@: Can you take another look? Thanks.

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
File base/message_loop/message_pump_win.cc (left):

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
base/message_loop/message_pump_win.cc:548: if (!item.has_valid_io_context ||
item.context->handler) {
On 2016/05/09 22:41:30, Lei Zhang wrote:
> So I didn't write this code and I'm only looking at it for the first time
ever.
> Are you saying |item.context->handler| is always initialized to be non-NULL,
and
> nobody sets it to NULL like in example #1 in
> base/message_loop/message_pump_win.h? Thus conditional always evaluates true,
> and everything else falls in place?

yes, it's always non-null

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
File base/message_loop/message_pump_win.cc (right):

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
base/message_loop/message_pump_win.cc:470: info.CompletionKey =
reinterpret_cast<void*>(handler);
On 2016/05/09 22:41:30, Lei Zhang wrote:
> reinterpret_cast no longer needed?

Done.

https://codereview.chromium.org/1954543002/diff/20001/ipc/ipc_channel_win.cc
File ipc/ipc_channel_win.cc (right):

https://codereview.chromium.org/1954543002/diff/20001/ipc/ipc_channel_win.cc#...
ipc/ipc_channel_win.cc:31: ChannelWin::State::State(ChannelWin* channel) :
is_pending(false) {
On 2016/05/09 22:41:30, Lei Zhang wrote:
> Do we still need the |channel| param?

Done.

[commit-bot: I haz the power, 2016-05-10 16:33:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954543002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954543002/40001

[Lei Zhang, 2016-05-10 19:15:25]

lgtm

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
File base/message_loop/message_pump_win.cc (right):

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
base/message_loop/message_pump_win.cc:470: info.CompletionKey =
reinterpret_cast<void*>(handler);
On 2016/05/10 16:33:17, fdoray wrote:
> On 2016/05/09 22:41:30, Lei Zhang wrote:
> > reinterpret_cast no longer needed?
> 
> Done.

Nope. :-P

[fdoray, 2016-05-10 19:40:20]

fdoray@chromium.org changed reviewers:
+ jam@chromium.org

[fdoray, 2016-05-10 19:40:21]

jam@: Can you review ipc/, mojo/ and net/? Thanks!

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
File base/message_loop/message_pump_win.cc (right):

https://codereview.chromium.org/1954543002/diff/20001/base/message_loop/messa...
base/message_loop/message_pump_win.cc:470: info.CompletionKey =
reinterpret_cast<void*>(handler);
On 2016/05/10 19:15:25, Lei Zhang wrote:
> On 2016/05/10 16:33:17, fdoray wrote:
> > On 2016/05/09 22:41:30, Lei Zhang wrote:
> > > reinterpret_cast no longer needed?
> > 
> > Done.
> 
> Nope. :-P

Done for realz.

[jam, 2016-05-11 18:14:47]

lgtm

[fdoray, 2016-05-11 18:16:57]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2016-05-11 18:16:57]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1954543002/#ps60001
(title: "CR thestig #17")

[commit-bot: I haz the power, 2016-05-11 18:17:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1954543002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1954543002/60001

[commit-bot: I haz the power, 2016-05-11 20:00:48]

Description was changed from

==========
Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459
==========

to

==========
Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459
==========

[commit-bot: I haz the power, 2016-05-11 20:00:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-11 20:02:52]

Description was changed from

==========
Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459
==========

to

==========
Remove handler from MessagePumpForIO::IOContext.

This member is not used by existing code.

We plan to redirect Tasks that run on the CACHE thread's
MessageLoopForIO to the new base/task_scheduler API. For
that, we have to replicate MessageLoopForIO's features in
base/task_scheduler. Removing unused code will make this
easier.

BUG=553459

Committed: https://crrev.com/324a072175552e65bc65edfa679bf00f573ee0a4
Cr-Commit-Position: refs/heads/master@{#393036}
==========

[commit-bot: I haz the power, 2016-05-11 20:02:53]

Patchset 4 (id:??) landed as
https://crrev.com/324a072175552e65bc65edfa679bf00f573ee0a4
Cr-Commit-Position: refs/heads/master@{#393036}