base/message_loop/message_loop_unittest.cc - Issue 1954543002: Remove handler from MessagePumpForIO::IOContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/message_loop/message_loop_unittest.cc

Issue 1954543002: Remove handler from MessagePumpForIO::IOContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_observers

Patch Set: CR thestig #17 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/message_loop/message_loop_unittest.cc

diff --git a/base/message_loop/message_loop_unittest.cc b/base/message_loop/message_loop_unittest.cc

index e0e46e2202456c0b39725e59811d8cdc08eeed31..7f9c652f39677d1e534f5fed71b27c784b5bee40 100644

--- a/base/message_loop/message_loop_unittest.cc

+++ b/base/message_loop/message_loop_unittest.cc

@@ -450,8 +450,6 @@ class TestIOHandler : public MessageLoopForIO::IOHandler {

TestIOHandler::TestIOHandler(const wchar_t* name, HANDLE signal, bool wait)

: signal_(signal), wait_(wait) {

memset(buffer_, 0, sizeof(buffer_));

- memset(&context_, 0, sizeof(context_));

- context_.handler = this;

file_.Set(CreateFile(name, GENERIC_READ, 0, NULL, OPEN_EXISTING,

FILE_FLAG_OVERLAPPED, NULL));

« no previous file with comments | « no previous file | base/message_loop/message_pump_win.h » ('j') | no next file with comments »