net/disk_cache/blockfile/file_win.cc - Issue 1954543002: Remove handler from MessagePumpForIO::IOContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/blockfile/file_win.cc

Issue 1954543002: Remove handler from MessagePumpForIO::IOContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_observers

Patch Set: CR thestig #17 Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/disk_cache/blockfile/file_win.cc

diff --git a/net/disk_cache/blockfile/file_win.cc b/net/disk_cache/blockfile/file_win.cc

index 1c5a9668763a9275f9d546133fe5958bffe7a1da..f38595d3bf14aa17e2442fc794302e9b7c2ed1fc 100644

--- a/net/disk_cache/blockfile/file_win.cc

+++ b/net/disk_cache/blockfile/file_win.cc

@@ -62,8 +62,6 @@ void CompletionHandler::OnIOCompleted(

MyOverlapped::MyOverlapped(disk_cache::File* file, size_t offset,

disk_cache::FileIOCallback* callback) {

- memset(this, 0, sizeof(*this));

- context_.handler = g_completion_handler.Pointer();

context_.overlapped.Offset = static_cast<DWORD>(offset);

file_ = file;

callback_ = callback;

« no previous file with comments | « net/base/file_stream_context_win.cc ('k') | no next file » | no next file with comments »