Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: ipc/ipc_channel_win.h

Issue 1954543002: Remove handler from MessagePumpForIO::IOContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_observers
Patch Set: CR thestig #17 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_io_handler_win.cc ('k') | ipc/ipc_channel_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IPC_IPC_CHANNEL_WIN_H_ 5 #ifndef IPC_IPC_CHANNEL_WIN_H_
6 #define IPC_IPC_CHANNEL_WIN_H_ 6 #define IPC_IPC_CHANNEL_WIN_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
75 // ProcessMessageForDelivery(). 75 // ProcessMessageForDelivery().
76 void FlushPrelimQueue(); 76 void FlushPrelimQueue();
77 77
78 // MessageLoop::IOHandler implementation. 78 // MessageLoop::IOHandler implementation.
79 void OnIOCompleted(base::MessageLoopForIO::IOContext* context, 79 void OnIOCompleted(base::MessageLoopForIO::IOContext* context,
80 DWORD bytes_transfered, 80 DWORD bytes_transfered,
81 DWORD error) override; 81 DWORD error) override;
82 82
83 private: 83 private:
84 struct State { 84 struct State {
85 explicit State(ChannelWin* channel); 85 State();
86 ~State(); 86 ~State();
87 base::MessageLoopForIO::IOContext context; 87 base::MessageLoopForIO::IOContext context;
88 bool is_pending; 88 bool is_pending = false;
89 }; 89 };
90 90
91 State input_state_; 91 State input_state_;
92 State output_state_; 92 State output_state_;
93 93
94 base::win::ScopedHandle pipe_; 94 base::win::ScopedHandle pipe_;
95 95
96 base::ProcessId peer_pid_; 96 base::ProcessId peer_pid_;
97 97
98 // Messages not yet ready to be sent are queued here. Messages removed from 98 // Messages not yet ready to be sent are queued here. Messages removed from
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 132
133 std::unique_ptr<base::ThreadChecker> thread_check_; 133 std::unique_ptr<base::ThreadChecker> thread_check_;
134 134
135 base::WeakPtrFactory<ChannelWin> weak_factory_; 135 base::WeakPtrFactory<ChannelWin> weak_factory_;
136 DISALLOW_COPY_AND_ASSIGN(ChannelWin); 136 DISALLOW_COPY_AND_ASSIGN(ChannelWin);
137 }; 137 };
138 138
139 } // namespace IPC 139 } // namespace IPC
140 140
141 #endif // IPC_IPC_CHANNEL_WIN_H_ 141 #endif // IPC_IPC_CHANNEL_WIN_H_
OLDNEW
« no previous file with comments | « device/serial/serial_io_handler_win.cc ('k') | ipc/ipc_channel_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698