Issue 19541007: Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19541007: Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache(). (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
mvstanton, Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache(). object_is_smi was always false so there's no need to actually have it. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15774

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+122 lines, -153 lines)			Patch
M	src/arm/builtins-arm.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/code-stubs-arm.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	5 chunks	+32 lines, -37 lines	0 comments	Download
M	src/ia32/builtins-ia32.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	4 chunks	+35 lines, -43 lines	0 comments	Download
M	src/mips/builtins-mips.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/mips/code-stubs-mips.cc	View	5 chunks	+29 lines, -34 lines	0 comments	Download
M	src/x64/builtins-x64.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	4 chunks	+26 lines, -31 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM. BTW: The previous name "object_is_smi" was horrible, if I see things correctly it meant ...

7 years, 5 months ago (2013-07-19 11:41:18 UTC) #2

Benedikt Meurer

7 years, 5 months ago (2013-07-19 11:43:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15774 (presubmit successful).