Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/arm/code-stubs-arm.h

Issue 19541007: Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 // the register object is found in the cache the generated code falls through 280 // the register object is found in the cache the generated code falls through
281 // with the result in the result register. The object and the result register 281 // with the result in the result register. The object and the result register
282 // can be the same. If the number is not found in the cache the code jumps to 282 // can be the same. If the number is not found in the cache the code jumps to
283 // the label not_found with only the content of register object unchanged. 283 // the label not_found with only the content of register object unchanged.
284 static void GenerateLookupNumberStringCache(MacroAssembler* masm, 284 static void GenerateLookupNumberStringCache(MacroAssembler* masm,
285 Register object, 285 Register object,
286 Register result, 286 Register result,
287 Register scratch1, 287 Register scratch1,
288 Register scratch2, 288 Register scratch2,
289 Register scratch3, 289 Register scratch3,
290 bool object_is_smi,
291 Label* not_found); 290 Label* not_found);
292 291
293 private: 292 private:
294 Major MajorKey() { return NumberToString; } 293 Major MajorKey() { return NumberToString; }
295 int MinorKey() { return 0; } 294 int MinorKey() { return 0; }
296 295
297 void Generate(MacroAssembler* masm); 296 void Generate(MacroAssembler* masm);
298 }; 297 };
299 298
300 299
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
576 575
577 class LookupModeBits: public BitField<LookupMode, 0, 1> {}; 576 class LookupModeBits: public BitField<LookupMode, 0, 1> {};
578 577
579 LookupMode mode_; 578 LookupMode mode_;
580 }; 579 };
581 580
582 581
583 } } // namespace v8::internal 582 } } // namespace v8::internal
584 583
585 #endif // V8_ARM_CODE_STUBS_ARM_H_ 584 #endif // V8_ARM_CODE_STUBS_ARM_H_
OLDNEW
« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/arm/code-stubs-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698