Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 19541007: Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1096 matching lines...) Expand 10 before | Expand all | Expand 10 after
1107 __ mov(eax, ebx); 1107 __ mov(eax, ebx);
1108 1108
1109 // Lookup the argument in the number to string cache. 1109 // Lookup the argument in the number to string cache.
1110 Label not_cached, argument_is_string; 1110 Label not_cached, argument_is_string;
1111 NumberToStringStub::GenerateLookupNumberStringCache( 1111 NumberToStringStub::GenerateLookupNumberStringCache(
1112 masm, 1112 masm,
1113 eax, // Input. 1113 eax, // Input.
1114 ebx, // Result. 1114 ebx, // Result.
1115 ecx, // Scratch 1. 1115 ecx, // Scratch 1.
1116 edx, // Scratch 2. 1116 edx, // Scratch 2.
1117 false, // Input is known to be smi?
1118 &not_cached); 1117 &not_cached);
1119 __ IncrementCounter(counters->string_ctor_cached_number(), 1); 1118 __ IncrementCounter(counters->string_ctor_cached_number(), 1);
1120 __ bind(&argument_is_string); 1119 __ bind(&argument_is_string);
1121 // ----------- S t a t e ------------- 1120 // ----------- S t a t e -------------
1122 // -- ebx : argument converted to string 1121 // -- ebx : argument converted to string
1123 // -- edi : constructor function 1122 // -- edi : constructor function
1124 // -- esp[0] : return address 1123 // -- esp[0] : return address
1125 // ----------------------------------- 1124 // -----------------------------------
1126 1125
1127 // Allocate a JSValue and put the tagged pointer into eax. 1126 // Allocate a JSValue and put the tagged pointer into eax.
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
1355 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR); 1354 Deoptimizer::EntryGenerator generator(masm, Deoptimizer::OSR);
1356 generator.Generate(); 1355 generator.Generate();
1357 } 1356 }
1358 1357
1359 1358
1360 #undef __ 1359 #undef __
1361 } 1360 }
1362 } // namespace v8::internal 1361 } // namespace v8::internal
1363 1362
1364 #endif // V8_TARGET_ARCH_IA32 1363 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/ia32/code-stubs-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698