Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: src/ia32/code-stubs-ia32.h

Issue 19541007: Cleanup useless parameter object_is_smi for NumberToStringStub::GenerateLookupNumberStringCache(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 // Generate code to do a lookup in the number string cache. If the number in 238 // Generate code to do a lookup in the number string cache. If the number in
239 // the register object is found in the cache the generated code falls through 239 // the register object is found in the cache the generated code falls through
240 // with the result in the result register. The object and the result register 240 // with the result in the result register. The object and the result register
241 // can be the same. If the number is not found in the cache the code jumps to 241 // can be the same. If the number is not found in the cache the code jumps to
242 // the label not_found with only the content of register object unchanged. 242 // the label not_found with only the content of register object unchanged.
243 static void GenerateLookupNumberStringCache(MacroAssembler* masm, 243 static void GenerateLookupNumberStringCache(MacroAssembler* masm,
244 Register object, 244 Register object,
245 Register result, 245 Register result,
246 Register scratch1, 246 Register scratch1,
247 Register scratch2, 247 Register scratch2,
248 bool object_is_smi,
249 Label* not_found); 248 Label* not_found);
250 249
251 private: 250 private:
252 Major MajorKey() { return NumberToString; } 251 Major MajorKey() { return NumberToString; }
253 int MinorKey() { return 0; } 252 int MinorKey() { return 0; }
254 253
255 void Generate(MacroAssembler* masm); 254 void Generate(MacroAssembler* masm);
256 }; 255 };
257 256
258 257
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 Register address_; 573 Register address_;
575 RememberedSetAction remembered_set_action_; 574 RememberedSetAction remembered_set_action_;
576 SaveFPRegsMode save_fp_regs_mode_; 575 SaveFPRegsMode save_fp_regs_mode_;
577 RegisterAllocation regs_; 576 RegisterAllocation regs_;
578 }; 577 };
579 578
580 579
581 } } // namespace v8::internal 580 } } // namespace v8::internal
582 581
583 #endif // V8_IA32_CODE_STUBS_IA32_H_ 582 #endif // V8_IA32_CODE_STUBS_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698