Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: src/ia32/lithium-codegen-ia32.cc

Issue 19541003: Consistently use HStringAdd instead of HCallStub with CodeStub::StringAdd. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1204 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 case CodeStub::SubString: { 1215 case CodeStub::SubString: {
1216 SubStringStub stub; 1216 SubStringStub stub;
1217 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1217 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1218 break; 1218 break;
1219 } 1219 }
1220 case CodeStub::NumberToString: { 1220 case CodeStub::NumberToString: {
1221 NumberToStringStub stub; 1221 NumberToStringStub stub;
1222 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1222 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1223 break; 1223 break;
1224 } 1224 }
1225 case CodeStub::StringAdd: {
1226 StringAddStub stub(NO_STRING_ADD_FLAGS);
1227 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1228 break;
1229 }
1230 case CodeStub::StringCompare: { 1225 case CodeStub::StringCompare: {
1231 StringCompareStub stub; 1226 StringCompareStub stub;
1232 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1227 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1233 break; 1228 break;
1234 } 1229 }
1235 case CodeStub::TranscendentalCache: { 1230 case CodeStub::TranscendentalCache: {
1236 TranscendentalCacheStub stub(instr->transcendental_type(), 1231 TranscendentalCacheStub stub(instr->transcendental_type(),
1237 TranscendentalCacheStub::TAGGED); 1232 TranscendentalCacheStub::TAGGED);
1238 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1233 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1239 break; 1234 break;
(...skipping 3626 matching lines...) Expand 10 before | Expand all | Expand 10 after
4866 void LCodeGen::DoStringLength(LStringLength* instr) { 4861 void LCodeGen::DoStringLength(LStringLength* instr) {
4867 Register string = ToRegister(instr->string()); 4862 Register string = ToRegister(instr->string());
4868 Register result = ToRegister(instr->result()); 4863 Register result = ToRegister(instr->result());
4869 __ mov(result, FieldOperand(string, String::kLengthOffset)); 4864 __ mov(result, FieldOperand(string, String::kLengthOffset));
4870 } 4865 }
4871 4866
4872 4867
4873 void LCodeGen::DoStringAdd(LStringAdd* instr) { 4868 void LCodeGen::DoStringAdd(LStringAdd* instr) {
4874 EmitPushTaggedOperand(instr->left()); 4869 EmitPushTaggedOperand(instr->left());
4875 EmitPushTaggedOperand(instr->right()); 4870 EmitPushTaggedOperand(instr->right());
4876 StringAddStub stub(NO_STRING_CHECK_IN_STUB); 4871 StringAddStub stub(instr->hydrogen()->flags());
4877 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 4872 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4878 } 4873 }
4879 4874
4880 4875
4881 void LCodeGen::DoInteger32ToDouble(LInteger32ToDouble* instr) { 4876 void LCodeGen::DoInteger32ToDouble(LInteger32ToDouble* instr) {
4882 if (CpuFeatures::IsSupported(SSE2)) { 4877 if (CpuFeatures::IsSupported(SSE2)) {
4883 CpuFeatureScope scope(masm(), SSE2); 4878 CpuFeatureScope scope(masm(), SSE2);
4884 LOperand* input = instr->value(); 4879 LOperand* input = instr->value();
4885 ASSERT(input->IsRegister() || input->IsStackSlot()); 4880 ASSERT(input->IsRegister() || input->IsStackSlot());
4886 LOperand* output = instr->result(); 4881 LOperand* output = instr->result();
(...skipping 1602 matching lines...) Expand 10 before | Expand all | Expand 10 after
6489 FixedArray::kHeaderSize - kPointerSize)); 6484 FixedArray::kHeaderSize - kPointerSize));
6490 __ bind(&done); 6485 __ bind(&done);
6491 } 6486 }
6492 6487
6493 6488
6494 #undef __ 6489 #undef __
6495 6490
6496 } } // namespace v8::internal 6491 } } // namespace v8::internal
6497 6492
6498 #endif // V8_TARGET_ARCH_IA32 6493 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/hydrogen-instructions.cc ('k') | src/mips/lithium-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698