Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 19541003: Consistently use HStringAdd instead of HCallStub with CodeStub::StringAdd. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1023 matching lines...) Expand 10 before | Expand all | Expand 10 after
1034 case CodeStub::SubString: { 1034 case CodeStub::SubString: {
1035 SubStringStub stub; 1035 SubStringStub stub;
1036 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1036 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1037 break; 1037 break;
1038 } 1038 }
1039 case CodeStub::NumberToString: { 1039 case CodeStub::NumberToString: {
1040 NumberToStringStub stub; 1040 NumberToStringStub stub;
1041 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1041 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1042 break; 1042 break;
1043 } 1043 }
1044 case CodeStub::StringAdd: {
1045 StringAddStub stub(NO_STRING_ADD_FLAGS);
1046 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1047 break;
1048 }
1049 case CodeStub::StringCompare: { 1044 case CodeStub::StringCompare: {
1050 StringCompareStub stub; 1045 StringCompareStub stub;
1051 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1046 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
1052 break; 1047 break;
1053 } 1048 }
1054 case CodeStub::TranscendentalCache: { 1049 case CodeStub::TranscendentalCache: {
1055 __ ldr(r0, MemOperand(sp, 0)); 1050 __ ldr(r0, MemOperand(sp, 0));
1056 TranscendentalCacheStub stub(instr->transcendental_type(), 1051 TranscendentalCacheStub stub(instr->transcendental_type(),
1057 TranscendentalCacheStub::TAGGED); 1052 TranscendentalCacheStub::TAGGED);
1058 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 1053 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
(...skipping 3473 matching lines...) Expand 10 before | Expand all | Expand 10 after
4532 Register object = ToRegister(instr->object()); 4527 Register object = ToRegister(instr->object());
4533 Register temp = ToRegister(instr->temp()); 4528 Register temp = ToRegister(instr->temp());
4534 __ TestJSArrayForAllocationSiteInfo(object, temp); 4529 __ TestJSArrayForAllocationSiteInfo(object, temp);
4535 DeoptimizeIf(eq, instr->environment()); 4530 DeoptimizeIf(eq, instr->environment());
4536 } 4531 }
4537 4532
4538 4533
4539 void LCodeGen::DoStringAdd(LStringAdd* instr) { 4534 void LCodeGen::DoStringAdd(LStringAdd* instr) {
4540 __ push(ToRegister(instr->left())); 4535 __ push(ToRegister(instr->left()));
4541 __ push(ToRegister(instr->right())); 4536 __ push(ToRegister(instr->right()));
4542 StringAddStub stub(NO_STRING_CHECK_IN_STUB); 4537 StringAddStub stub(instr->hydrogen()->flags());
4543 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 4538 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4544 } 4539 }
4545 4540
4546 4541
4547 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) { 4542 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {
4548 class DeferredStringCharCodeAt: public LDeferredCode { 4543 class DeferredStringCharCodeAt: public LDeferredCode {
4549 public: 4544 public:
4550 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr) 4545 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr)
4551 : LDeferredCode(codegen), instr_(instr) { } 4546 : LDeferredCode(codegen), instr_(instr) { }
4552 virtual void Generate() { codegen()->DoDeferredStringCharCodeAt(instr_); } 4547 virtual void Generate() { codegen()->DoDeferredStringCharCodeAt(instr_); }
(...skipping 1254 matching lines...) Expand 10 before | Expand all | Expand 10 after
5807 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5802 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5808 __ ldr(result, FieldMemOperand(scratch, 5803 __ ldr(result, FieldMemOperand(scratch,
5809 FixedArray::kHeaderSize - kPointerSize)); 5804 FixedArray::kHeaderSize - kPointerSize));
5810 __ bind(&done); 5805 __ bind(&done);
5811 } 5806 }
5812 5807
5813 5808
5814 #undef __ 5809 #undef __
5815 5810
5816 } } // namespace v8::internal 5811 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698