Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 19541003: Consistently use HStringAdd instead of HCallStub with CodeStub::StringAdd. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 903 matching lines...) Expand 10 before | Expand all | Expand 10 after
914 case CodeStub::SubString: { 914 case CodeStub::SubString: {
915 SubStringStub stub; 915 SubStringStub stub;
916 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 916 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
917 break; 917 break;
918 } 918 }
919 case CodeStub::NumberToString: { 919 case CodeStub::NumberToString: {
920 NumberToStringStub stub; 920 NumberToStringStub stub;
921 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 921 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
922 break; 922 break;
923 } 923 }
924 case CodeStub::StringAdd: {
925 StringAddStub stub(NO_STRING_ADD_FLAGS);
926 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
927 break;
928 }
929 case CodeStub::StringCompare: { 924 case CodeStub::StringCompare: {
930 StringCompareStub stub; 925 StringCompareStub stub;
931 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 926 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
932 break; 927 break;
933 } 928 }
934 case CodeStub::TranscendentalCache: { 929 case CodeStub::TranscendentalCache: {
935 TranscendentalCacheStub stub(instr->transcendental_type(), 930 TranscendentalCacheStub stub(instr->transcendental_type(),
936 TranscendentalCacheStub::TAGGED); 931 TranscendentalCacheStub::TAGGED);
937 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 932 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
938 break; 933 break;
(...skipping 3378 matching lines...) Expand 10 before | Expand all | Expand 10 after
4317 Register object = ToRegister(instr->object()); 4312 Register object = ToRegister(instr->object());
4318 Register temp = ToRegister(instr->temp()); 4313 Register temp = ToRegister(instr->temp());
4319 __ TestJSArrayForAllocationSiteInfo(object, temp); 4314 __ TestJSArrayForAllocationSiteInfo(object, temp);
4320 DeoptimizeIf(equal, instr->environment()); 4315 DeoptimizeIf(equal, instr->environment());
4321 } 4316 }
4322 4317
4323 4318
4324 void LCodeGen::DoStringAdd(LStringAdd* instr) { 4319 void LCodeGen::DoStringAdd(LStringAdd* instr) {
4325 EmitPushTaggedOperand(instr->left()); 4320 EmitPushTaggedOperand(instr->left());
4326 EmitPushTaggedOperand(instr->right()); 4321 EmitPushTaggedOperand(instr->right());
4327 StringAddStub stub(NO_STRING_CHECK_IN_STUB); 4322 StringAddStub stub(instr->hydrogen()->flags());
4328 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr); 4323 CallCode(stub.GetCode(isolate()), RelocInfo::CODE_TARGET, instr);
4329 } 4324 }
4330 4325
4331 4326
4332 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) { 4327 void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {
4333 class DeferredStringCharCodeAt: public LDeferredCode { 4328 class DeferredStringCharCodeAt: public LDeferredCode {
4334 public: 4329 public:
4335 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr) 4330 DeferredStringCharCodeAt(LCodeGen* codegen, LStringCharCodeAt* instr)
4336 : LDeferredCode(codegen), instr_(instr) { } 4331 : LDeferredCode(codegen), instr_(instr) { }
4337 virtual void Generate() { codegen()->DoDeferredStringCharCodeAt(instr_); } 4332 virtual void Generate() { codegen()->DoDeferredStringCharCodeAt(instr_); }
(...skipping 1188 matching lines...) Expand 10 before | Expand all | Expand 10 after
5526 FixedArray::kHeaderSize - kPointerSize)); 5521 FixedArray::kHeaderSize - kPointerSize));
5527 __ bind(&done); 5522 __ bind(&done);
5528 } 5523 }
5529 5524
5530 5525
5531 #undef __ 5526 #undef __
5532 5527
5533 } } // namespace v8::internal 5528 } } // namespace v8::internal
5534 5529
5535 #endif // V8_TARGET_ARCH_X64 5530 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-codegen-mips.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698