Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3712)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/gn_migration.gypi ('K') | « cc/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 17d6ca845041f1f375adc7044aba0b2acc14c9e3..5a38977a30762d2d4397527e8ae6207bf01354c8 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -131,8 +131,6 @@ if (!is_android && !is_mac) {
":chrome_dll",
":chrome_exe_version",
":file_pre_reader",
-
- # 'chrome_nacl_win64" TODO(GYP) bug 512869
brettw 2016/05/04 19:51:28 This is nacl64.exe which gets build inside of nati
"//base",
"//breakpad:breakpad_handler",
"//breakpad:breakpad_sender",
@@ -1331,7 +1329,7 @@ if (is_linux) {
args = [
"./" + rebase_path(dump_syms_binary, root_build_dir),
- "0", # TODO(GYP) This is linux_strip_binary if it is needed.
+ "0", # strip_binary = false
rebase_path(chrome_binary, root_build_dir),
rebase_path(symbol_file, root_build_dir),
]
« build/gn_migration.gypi ('K') | « cc/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698