Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/gn_migration.gypi

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | build/secondary/third_party/crashpad/crashpad/util/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gn_migration.gypi
diff --git a/build/gn_migration.gypi b/build/gn_migration.gypi
index 3f3358d3893b350c777da7e56733c8db20746424..b6657865e09b51e4c6759851324e345e90586ee1 100644
--- a/build/gn_migration.gypi
+++ b/build/gn_migration.gypi
@@ -14,9 +14,6 @@
#
# 'gyp_remaining' lists all of the targets that still need to be converted,
# i.e., all of the other (non-empty) targets that a GYP build will build.
-#
-# TODO(GYP): crbug.com/481694. Add a build step to the bot that enforces the
-# above contracts.
brettw 2016/05/04 19:51:28 Not going to do this.
{
'includes': [
« build/config/compiler/BUILD.gn ('K') | « build/config/compiler/BUILD.gn ('k') | build/secondary/third_party/crashpad/crashpad/util/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698