Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2158)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/gn_migration.gypi ('K') | « build/secondary/third_party/crashpad/crashpad/util/BUILD.gn ('k') | chrome/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/BUILD.gn
diff --git a/cc/BUILD.gn b/cc/BUILD.gn
index cf4cd6a2966175fd4cc0e757163ff6d12856ff18..20b9d3e1b6f550e8fb9777fd98df25ccd7425f3c 100644
--- a/cc/BUILD.gn
+++ b/cc/BUILD.gn
@@ -749,16 +749,13 @@ source_set("test_support") {
"//skia",
"//testing/gmock",
"//testing/gtest",
+ "//third_party/mesa:osmesa",
"//ui/gfx",
"//ui/gfx:test_support",
"//ui/gfx/geometry",
"//ui/gl",
"//ui/gl:test_support",
]
-
- if (!is_android) { # TODO(GYP) Enable on Android when osmesa links.
- deps += [ "//third_party/mesa:osmesa" ]
- }
}
test("cc_unittests") {
« build/gn_migration.gypi ('K') | « build/secondary/third_party/crashpad/crashpad/util/BUILD.gn ('k') | chrome/BUILD.gn » ('j') | chrome/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698