Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/BUILD.gn

Issue 1953523002: Address some TODO(GYP)s in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/BUILD.gn ('K') | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/BUILD.gn
diff --git a/chrome/browser/BUILD.gn b/chrome/browser/BUILD.gn
index 214ae85baeb32e879394748801babc07845bf731..c4c24a930781405287f31465ab30e82fae66baf7 100644
--- a/chrome/browser/BUILD.gn
+++ b/chrome/browser/BUILD.gn
@@ -813,13 +813,6 @@ source_set("browser") {
deps += [ ":rlz" ]
}
- # TODO(GYP)
- # Temporary fix to break the browser target into smaller chunks so it
- # will link with goma builds.
- #["OS=="win" and chromium_win_pch==0", {
- # "msvs_shard": 4,
- #}],
-
if (is_win) {
sources +=
rebase_path(gypi_values.chrome_browser_win_sources, ".", "//chrome")
« chrome/BUILD.gn ('K') | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698