[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,tnagel@chromium.org

Committed: https://crrev.com/0e40811ddc3347d46421380adfce64c0573141c5
Cr-Commit-Position: refs/heads/master@{#391523}

[Robert Sesek, 2016-05-03 17:50:26]

Description was changed from

==========
[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,atwilson@chromium.org
==========

to

==========
[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,tnagel@chromium.org
==========

[Robert Sesek, 2016-05-03 17:50:26]

rsesek@chromium.org changed reviewers:
+ tnagel@chromium.org
- atwilson@chromium.org

[Robert Sesek, 2016-05-03 17:50:56]

mark: overall review
tnagel: //components/policy

[Mark Mentovai, 2016-05-03 17:54:51]

LGTM

https://codereview.chromium.org/1950493002/diff/1/build/util/branding.gni
File build/util/branding.gni (right):

https://codereview.chromium.org/1950493002/diff/1/build/util/branding.gni#new...
build/util/branding.gni:30: "scope",
This change from “trim string” to “scope” is the most confusing thing. I see
that you’re changing from a single string to a whole dicty thing, but “scope”
doesn’t tell me what it actually does, and I want to make sure that it’s right
here, and that full_name has the same semantics as it did before.

[Robert Sesek, 2016-05-03 18:02:39]

https://codereview.chromium.org/1950493002/diff/1/build/util/branding.gni
File build/util/branding.gni (right):

https://codereview.chromium.org/1950493002/diff/1/build/util/branding.gni#new...
build/util/branding.gni:30: "scope",
On 2016/05/03 17:54:51, Mark Mentovai wrote:
> This change from “trim string” to “scope” is the most confusing thing. I see
> that you’re changing from a single string to a whole dicty thing, but “scope”
> doesn’t tell me what it actually does, and I want to make sure that it’s right
> here, and that full_name has the same semantics as it did before.

Yeah, it's a little confusing, but I mostly just copied this from
build/util/version.gni and it does this. The dicty thing is:

{
  full_name = "Chromium"
  short_name = "Chromium"
  bundle_id = "org.chromium.Chromium"
  creator_code = "Cr24"
}


(you can use |print(anything)| in gn to have it output when you `gn gen`)

[Robert Sesek, 2016-05-04 14:43:43]

rsesek@chromium.org changed reviewers:
+ jochen@chromium.org

[Robert Sesek, 2016-05-04 14:43:44]

+jochen for //components and //chrome OWNERS

[jochen (gone - plz use gerrit), 2016-05-04 14:46:11]

lgtm

[Robert Sesek, 2016-05-04 14:50:09]

The CQ bit was checked by rsesek@chromium.org

[commit-bot: I haz the power, 2016-05-04 14:50:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950493002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950493002/1

[commit-bot: I haz the power, 2016-05-04 15:58:25]

Description was changed from

==========
[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,tnagel@chromium.org
==========

to

==========
[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,tnagel@chromium.org
==========

[commit-bot: I haz the power, 2016-05-04 15:58:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-04 16:00:00]

Description was changed from

==========
[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,tnagel@chromium.org
==========

to

==========
[Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it.

This also updates //components/policy to produce the manifest bundle with the
proper branding.

BUG=431177
R=mark@chromium.org,tnagel@chromium.org

Committed: https://crrev.com/0e40811ddc3347d46421380adfce64c0573141c5
Cr-Commit-Position: refs/heads/master@{#391523}
==========

[commit-bot: I haz the power, 2016-05-04 16:00:01]

Patchset 1 (id:??) landed as
https://crrev.com/0e40811ddc3347d46421380adfce64c0573141c5
Cr-Commit-Position: refs/heads/master@{#391523}