Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/BUILD.gn

Issue 1950493002: [Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index df46adc4200317f8c0a966288872cd225a762745..5c0e4ec64918e9e82b7ca6033eb7a673c3b16fad 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -441,6 +441,11 @@ if (is_win) {
output_name = chrome_product_full_name
info_plist = "app/app-Info.plist"
+ extra_substitutions = [
+ "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
+ "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
+ "CHROMIUM_CREATOR=$chrome_mac_creator_code",
+ ]
sources = [
"app/chrome_exe_main_mac.c",
@@ -524,19 +529,17 @@ if (is_win) {
bundle_data("chrome_resources") {
sources = [
+ "$root_out_dir/$chrome_mac_bundle_id.manifest",
"app/theme/$branding_path_component/mac/app.icns",
"app/theme/$branding_path_component/mac/document.icns",
"browser/ui/cocoa/applescript/scripting.sdef",
-
- # TODO(rsesek): mac_bundle_id.manifest
]
-
outputs = [
"{{bundle_resources_dir}}/{{source_file_part}}",
]
-
- deps = [
+ public_deps = [
":chrome_app_strings",
+ "//components/policy:chrome_manifest_bundle",
]
}
@@ -558,6 +561,10 @@ if (is_win) {
output_name = chrome_helper_name
info_plist = "app/helper-Info.plist"
+ extra_substitutions = [
+ "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
+ "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
+ ]
sources = [
"app/chrome_exe_main_mac.c",
@@ -667,6 +674,10 @@ if (is_win) {
]
info_plist = "app/framework-Info.plist"
+ extra_substitutions = [
+ "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
+ "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
+ ]
deps = [
":browser_dependencies",

Powered by Google App Engine
This is Rietveld 408576698