Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949623002: [Mac/GN] Run tweak_info_plist on //chrome targets. (Closed)

Created:
4 years, 7 months ago by Robert Sesek
Modified:
4 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-bundle-id
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Run tweak_info_plist on //chrome targets. BUG=431177 R=thakis@chromium.org Committed: https://crrev.com/cf1a6c3377da1575adf9ba73b9eb18fb67c48e9f Cr-Commit-Position: refs/heads/master@{#391565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -6 lines) Patch
M chrome/BUILD.gn View 6 chunks +39 lines, -5 lines 0 comments Download
M chrome/app_shim/BUILD.gn View 2 chunks +11 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1950493002 Patch 1

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 7 months ago (2016-05-03 17:53:21 UTC) #1
Nico
lgtm
4 years, 7 months ago (2016-05-03 17:54:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949623002/1
4 years, 7 months ago (2016-05-04 16:03:09 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 18:16:03 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:17:23 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cf1a6c3377da1575adf9ba73b9eb18fb67c48e9f
Cr-Commit-Position: refs/heads/master@{#391565}

Powered by Google App Engine
This is Rietveld 408576698