Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: build/config/mac/rules.gni

Issue 1950493002: [Mac/GN] Move the bundle ID and creator code into the BRANDING file, and use it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/util/branding.gni » ('j') | build/util/branding.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/rules.gni
diff --git a/build/config/mac/rules.gni b/build/config/mac/rules.gni
index 3c51905d42557e0516bdd08dc4dc8d7ce55cf703..224fd70b640c97600d023762c985373d5474122d 100644
--- a/build/config/mac/rules.gni
+++ b/build/config/mac/rules.gni
@@ -139,6 +139,10 @@ template("mac_xib_bundle_data") {
# structure will not be created, and build output will go directly
# into the framework subdirectory.
#
+# extra_substitutions:
+# (optional) string array, 'key=value' pairs for extra fields which are
+# specified in a source Info.plist template.
+#
# See "gn help shared_library" for more information on arguments supported
# by shared library target.
template("mac_framework_bundle") {
@@ -154,9 +158,10 @@ template("mac_framework_bundle") {
}
forward_variables_from(invoker,
[
- "testonly",
+ "extra_substitutions",
"info_plist",
"info_plist_target",
+ "testonly",
])
}
@@ -203,6 +208,10 @@ template("mac_framework_bundle") {
# extra_configs:
# (optional) list of label, additional configs to apply to the
# executable target.
+#
+# extra_substitutions:
+# (optional) string array, 'key=value' pairs for extra fields which are
+# specified in a source Info.plist template.
template("mac_app_bundle") {
_target_name = target_name
_output_name = target_name
@@ -219,9 +228,10 @@ template("mac_app_bundle") {
executable_name = _output_name
forward_variables_from(invoker,
[
- "testonly",
+ "extra_substitutions",
"info_plist",
"info_plist_target",
+ "testonly",
])
}
« no previous file with comments | « no previous file | build/util/branding.gni » ('j') | build/util/branding.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698