Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: chrome/BUILD.gn

Issue 1949623002: [Mac/GN] Run tweak_info_plist on //chrome targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-id
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/app_shim/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/buildflag_header.gni") 5 import("//build/buildflag_header.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/features.gni") 8 import("//build/config/features.gni")
9 import("//build/config/locales.gni") 9 import("//build/config/locales.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 14 matching lines...) Expand all
25 # 25 #
26 # TODO(sebmarchand): Add support for the PGU (update) phase. 26 # TODO(sebmarchand): Add support for the PGU (update) phase.
27 chrome_pgo_phase = 0 27 chrome_pgo_phase = 0
28 } 28 }
29 29
30 if (is_android) { 30 if (is_android) {
31 import("//build/config/android/rules.gni") 31 import("//build/config/android/rules.gni")
32 } else if (is_mac) { 32 } else if (is_mac) {
33 import("//build/compiled_action.gni") 33 import("//build/compiled_action.gni")
34 import("//build/config/mac/rules.gni") 34 import("//build/config/mac/rules.gni")
35 import("//build/mac/tweak_info_plist.gni")
35 import("//build/util/branding.gni") 36 import("//build/util/branding.gni")
36 import("//build/util/version.gni") 37 import("//build/util/version.gni")
37 import("//build_overrides/v8.gni") 38 import("//build_overrides/v8.gni")
38 } 39 }
39 40
40 if (is_win) { 41 if (is_win) {
41 action("reorder_imports") { 42 action("reorder_imports") {
42 script = "//build/win/reorder-imports.py" 43 script = "//build/win/reorder-imports.py"
43 44
44 # See comment in chrome_dll.gypi in the hardlink_to_output 45 # See comment in chrome_dll.gypi in the hardlink_to_output
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 if (is_linux || is_win) { 100 if (is_linux || is_win) {
100 data += [ 101 data += [
101 "$root_out_dir/chrome_100_percent.pak", 102 "$root_out_dir/chrome_100_percent.pak",
102 "$root_out_dir/locales/en-US.pak", 103 "$root_out_dir/locales/en-US.pak",
103 "$root_out_dir/locales/fr.pak", 104 "$root_out_dir/locales/fr.pak",
104 ] 105 ]
105 } 106 }
106 107
107 data_deps = [] 108 data_deps = []
108 109
109 # TODO(GYP) mac_bundle_resources, xcode_settings
110
111 if (is_win) { 110 if (is_win) {
112 sources += [ 111 sources += [
113 "app/chrome_crash_reporter_client_win.cc", 112 "app/chrome_crash_reporter_client_win.cc",
114 "app/chrome_crash_reporter_client_win.h", 113 "app/chrome_crash_reporter_client_win.h",
115 "app/chrome_exe.rc", 114 "app/chrome_exe.rc",
116 "app/chrome_exe_load_config_win.cc", 115 "app/chrome_exe_load_config_win.cc",
117 "app/chrome_exe_main_win.cc", 116 "app/chrome_exe_main_win.cc",
118 "app/chrome_watcher_client_win.cc", 117 "app/chrome_watcher_client_win.cc",
119 "app/chrome_watcher_client_win.h", 118 "app/chrome_watcher_client_win.h",
120 "app/chrome_watcher_command_line_win.cc", 119 "app/chrome_watcher_command_line_win.cc",
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 ":chrome_initial", 429 ":chrome_initial",
431 ] 430 ]
432 } 431 }
433 432
434 group("chrome_initial") { 433 group("chrome_initial") {
435 deps = [ 434 deps = [
436 ":chrome_app", 435 ":chrome_app",
437 ] 436 ]
438 } 437 }
439 438
439 tweak_info_plist("chrome_app_plist") {
440 info_plist = "app/app-Info.plist"
441 args = [
442 "--breakpad=0",
443
444 #"--keystone=???", # TODO(rsesek): Keystone.
445
446 "--scm=1",
447 "--bundle_id=$chrome_mac_bundle_id",
448 ]
449 }
450
440 mac_app_bundle("chrome_app") { 451 mac_app_bundle("chrome_app") {
441 output_name = chrome_product_full_name 452 output_name = chrome_product_full_name
442 453
443 info_plist = "app/app-Info.plist" 454 info_plist_target = ":chrome_app_plist"
444 extra_substitutions = [ 455 extra_substitutions = [
445 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id", 456 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
446 "CHROMIUM_SHORT_NAME=$chrome_product_short_name", 457 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
447 "CHROMIUM_CREATOR=$chrome_mac_creator_code", 458 "CHROMIUM_CREATOR=$chrome_mac_creator_code",
448 ] 459 ]
449 460
450 sources = [ 461 sources = [
451 "app/chrome_exe_main_mac.c", 462 "app/chrome_exe_main_mac.c",
452 ] 463 ]
453 464
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
550 ] 561 ]
551 outputs = [ 562 outputs = [
552 "{{bundle_root_dir}}/Versions/$chrome_version_full/{{source_file_part}}", 563 "{{bundle_root_dir}}/Versions/$chrome_version_full/{{source_file_part}}",
553 ] 564 ]
554 public_deps = [ 565 public_deps = [
555 ":chrome_framework", 566 ":chrome_framework",
556 ":chrome_helper_app", 567 ":chrome_helper_app",
557 ] 568 ]
558 } 569 }
559 570
571 tweak_info_plist("chrome_helper_plist") {
572 info_plist = "app/helper-Info.plist"
573 args = [
574 "--breakpad=0",
575 "--keystone=0",
576 "--scm=0",
577 ]
578 }
579
560 mac_app_bundle("chrome_helper_app") { 580 mac_app_bundle("chrome_helper_app") {
561 output_name = chrome_helper_name 581 output_name = chrome_helper_name
562 582
563 info_plist = "app/helper-Info.plist" 583 info_plist_target = ":chrome_helper_plist"
564 extra_substitutions = [ 584 extra_substitutions = [
565 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id", 585 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
566 "CHROMIUM_SHORT_NAME=$chrome_product_short_name", 586 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
567 ] 587 ]
568 588
569 sources = [ 589 sources = [
570 "app/chrome_exe_main_mac.c", 590 "app/chrome_exe_main_mac.c",
571 ] 591 ]
572 592
573 defines = [ "HELPER_EXECUTABLE" ] 593 defines = [ "HELPER_EXECUTABLE" ]
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
648 668
649 if (v8_use_external_startup_data) { 669 if (v8_use_external_startup_data) {
650 sources += [ 670 sources += [
651 "$root_out_dir/natives_blob.bin", 671 "$root_out_dir/natives_blob.bin",
652 "$root_out_dir/snapshot_blob.bin", 672 "$root_out_dir/snapshot_blob.bin",
653 ] 673 ]
654 public_deps += [ "//v8" ] 674 public_deps += [ "//v8" ]
655 } 675 }
656 } 676 }
657 677
678 tweak_info_plist("chrome_framework_plist") {
679 info_plist = "app/framework-Info.plist"
680 args = [
681 "--breakpad=1",
682
683 #"--breakpad_uploads=???", # TODO(rsesek): Breakpad uploads.
684
685 "--keystone=0",
686 "--scm=1",
687 "--branding",
688 chrome_product_short_name,
689 ]
690 }
691
658 mac_framework_bundle("chrome_framework") { 692 mac_framework_bundle("chrome_framework") {
659 output_name = chrome_framework_name 693 output_name = chrome_framework_name
660 694
661 configs += [ "//build/config/compiler:wexit_time_destructors" ] 695 configs += [ "//build/config/compiler:wexit_time_destructors" ]
662 696
663 sources = [ 697 sources = [
664 "app/chrome_command_ids.h", 698 "app/chrome_command_ids.h",
665 "app/chrome_crash_reporter_client.cc", 699 "app/chrome_crash_reporter_client.cc",
666 "app/chrome_crash_reporter_client.h", 700 "app/chrome_crash_reporter_client.h",
667 "app/chrome_crash_reporter_client_mac.mm", 701 "app/chrome_crash_reporter_client_mac.mm",
668 "app/chrome_dll_resource.h", 702 "app/chrome_dll_resource.h",
669 "app/chrome_main.cc", 703 "app/chrome_main.cc",
670 "app/chrome_main_delegate.cc", 704 "app/chrome_main_delegate.cc",
671 "app/chrome_main_delegate.h", 705 "app/chrome_main_delegate.h",
672 "app/chrome_main_mac.h", 706 "app/chrome_main_mac.h",
673 "app/chrome_main_mac.mm", 707 "app/chrome_main_mac.mm",
674 ] 708 ]
675 709
676 info_plist = "app/framework-Info.plist" 710 info_plist_target = ":chrome_framework_plist"
677 extra_substitutions = [ 711 extra_substitutions = [
678 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id", 712 "CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
679 "CHROMIUM_SHORT_NAME=$chrome_product_short_name", 713 "CHROMIUM_SHORT_NAME=$chrome_product_short_name",
680 ] 714 ]
681 715
682 deps = [ 716 deps = [
683 ":browser_dependencies", 717 ":browser_dependencies",
684 ":child_dependencies", 718 ":child_dependencies",
685 ":chrome_framework_helpers", 719 ":chrome_framework_helpers",
686 ":chrome_framework_locales", 720 ":chrome_framework_locales",
(...skipping 671 matching lines...) Expand 10 before | Expand all | Expand 10 after
1358 "//chrome/app/theme/$branding_path_component/product_logo_48.png", 1392 "//chrome/app/theme/$branding_path_component/product_logo_48.png",
1359 "//chrome/tools/build/linux/chrome-wrapper", 1393 "//chrome/tools/build/linux/chrome-wrapper",
1360 "//third_party/xdg-utils/scripts/xdg-mime", 1394 "//third_party/xdg-utils/scripts/xdg-mime",
1361 "//third_party/xdg-utils/scripts/xdg-settings", 1395 "//third_party/xdg-utils/scripts/xdg-settings",
1362 ] 1396 ]
1363 outputs = [ 1397 outputs = [
1364 "$root_out_dir/{{source_file_part}}", 1398 "$root_out_dir/{{source_file_part}}",
1365 ] 1399 ]
1366 } 1400 }
1367 } 1401 }
OLDNEW
« no previous file with comments | « no previous file | chrome/app_shim/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698