Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1856)

Unified Diff: chrome/BUILD.gn

Issue 1949623002: [Mac/GN] Run tweak_info_plist on //chrome targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-id
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/app_shim/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index 5c0e4ec64918e9e82b7ca6033eb7a673c3b16fad..15df1295bdf4a79cbf391f0de458f0478aed1736 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -32,6 +32,7 @@ if (is_android) {
} else if (is_mac) {
import("//build/compiled_action.gni")
import("//build/config/mac/rules.gni")
+ import("//build/mac/tweak_info_plist.gni")
import("//build/util/branding.gni")
import("//build/util/version.gni")
import("//build_overrides/v8.gni")
@@ -106,8 +107,6 @@ if (!is_android && !is_mac) {
data_deps = []
- # TODO(GYP) mac_bundle_resources, xcode_settings
-
if (is_win) {
sources += [
"app/chrome_crash_reporter_client_win.cc",
@@ -437,10 +436,22 @@ if (is_win) {
]
}
+ tweak_info_plist("chrome_app_plist") {
+ info_plist = "app/app-Info.plist"
+ args = [
+ "--breakpad=0",
+
+ #"--keystone=???", # TODO(rsesek): Keystone.
+
+ "--scm=1",
+ "--bundle_id=$chrome_mac_bundle_id",
+ ]
+ }
+
mac_app_bundle("chrome_app") {
output_name = chrome_product_full_name
- info_plist = "app/app-Info.plist"
+ info_plist_target = ":chrome_app_plist"
extra_substitutions = [
"CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
"CHROMIUM_SHORT_NAME=$chrome_product_short_name",
@@ -557,10 +568,19 @@ if (is_win) {
]
}
+ tweak_info_plist("chrome_helper_plist") {
+ info_plist = "app/helper-Info.plist"
+ args = [
+ "--breakpad=0",
+ "--keystone=0",
+ "--scm=0",
+ ]
+ }
+
mac_app_bundle("chrome_helper_app") {
output_name = chrome_helper_name
- info_plist = "app/helper-Info.plist"
+ info_plist_target = ":chrome_helper_plist"
extra_substitutions = [
"CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
"CHROMIUM_SHORT_NAME=$chrome_product_short_name",
@@ -655,6 +675,20 @@ if (is_win) {
}
}
+ tweak_info_plist("chrome_framework_plist") {
+ info_plist = "app/framework-Info.plist"
+ args = [
+ "--breakpad=1",
+
+ #"--breakpad_uploads=???", # TODO(rsesek): Breakpad uploads.
+
+ "--keystone=0",
+ "--scm=1",
+ "--branding",
+ chrome_product_short_name,
+ ]
+ }
+
mac_framework_bundle("chrome_framework") {
output_name = chrome_framework_name
@@ -673,7 +707,7 @@ if (is_win) {
"app/chrome_main_mac.mm",
]
- info_plist = "app/framework-Info.plist"
+ info_plist_target = ":chrome_framework_plist"
extra_substitutions = [
"CHROMIUM_BUNDLE_ID=$chrome_mac_bundle_id",
"CHROMIUM_SHORT_NAME=$chrome_product_short_name",
« no previous file with comments | « no previous file | chrome/app_shim/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698