Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1949113004: Add icons for network cr-elements to cr-icons for Chrome OS. (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CrNetworkCrOS
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add icons for network cr-elements to cr-icons for Chrome OS. This is a follow-up to crrev.com/1950163003 and crrev.com/1947533002. BUG=605821 R=stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/441c30696670030f8c941120f8aeeea51ee87d4b Cr-Commit-Position: refs/heads/master@{#392507}

Patch Set 1 #

Total comments: 8

Patch Set 2 : clarify sources #

Patch Set 3 : rebase #

Patch Set 4 : rebase on poly-icons version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M ui/webui/resources/cr_elements/icons.html View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.html View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_list_item.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_network_indicator.html View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (3 generated)
michaelpg
PTAL, see crrev.com/1947533002 for context. (We've created cr-icons to list icons specific to cr-elements; once ...
4 years, 7 months ago (2016-05-05 15:01:15 UTC) #2
stevenjb
https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html File ui/webui/resources/cr_elements/cr_icons.html (right): https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html#newcode7 ui/webui/resources/cr_elements/cr_icons.html:7: --> Not to be a pain but, is this ...
4 years, 7 months ago (2016-05-05 16:29:07 UTC) #3
michaelpg
https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html File ui/webui/resources/cr_elements/cr_icons.html (right): https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html#newcode7 ui/webui/resources/cr_elements/cr_icons.html:7: --> On 2016/05/05 16:29:07, stevenjb wrote: > Not to ...
4 years, 7 months ago (2016-05-05 21:13:33 UTC) #4
stevenjb
https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html File ui/webui/resources/cr_elements/cr_icons.html (right): https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html#newcode7 ui/webui/resources/cr_elements/cr_icons.html:7: --> On 2016/05/05 21:13:33, michaelpg wrote: > On 2016/05/05 ...
4 years, 7 months ago (2016-05-05 21:24:21 UTC) #5
michaelpg
https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html File ui/webui/resources/cr_elements/cr_icons.html (right): https://codereview.chromium.org/1949113004/diff/1/ui/webui/resources/cr_elements/cr_icons.html#newcode7 ui/webui/resources/cr_elements/cr_icons.html:7: --> On 2016/05/05 21:24:21, stevenjb wrote: > On 2016/05/05 ...
4 years, 7 months ago (2016-05-09 13:53:36 UTC) #6
stevenjb
lgtm
4 years, 7 months ago (2016-05-09 16:13:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949113004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949113004/60001
4 years, 7 months ago (2016-05-10 00:40:20 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-10 01:28:00 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 01:29:06 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/441c30696670030f8c941120f8aeeea51ee87d4b
Cr-Commit-Position: refs/heads/master@{#392507}

Powered by Google App Engine
This is Rietveld 408576698