Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1964493002: MD Downloads: use custom iconset (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CrIconsCrOS
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: use custom iconset Instead of including all 299 SVG definitions from iron-icons, put the 2 icons we're using into our own iconset. dbeam: i'm not sure how to test this, aside from Inspector. do you have any unsafe download examples? BUG=605821 R=dbeam@chromium.org NOPRESUBMIT=true # crisper.js CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6 Cr-Commit-Position: refs/heads/master@{#392539}

Patch Set 1 #

Patch Set 2 : newline #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -496 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 3 chunks +181 lines, -181 lines 0 comments Download
A chrome/browser/resources/md_downloads/icons.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.css View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/item.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 4 chunks +23 lines, -310 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
michaelpg
PTAL at 300 removed lines.
4 years, 7 months ago (2016-05-09 14:08:04 UTC) #3
Dan Beam
lgtm unsafe on some platforms: http://danbeam.org/hacks/slow-auto.jar
4 years, 7 months ago (2016-05-09 14:43:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1964493002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1964493002/40001
4 years, 7 months ago (2016-05-10 02:42:32 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-10 03:49:01 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 03:51:42 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f53081fa0b0558c466a15994d32461a03098dac6
Cr-Commit-Position: refs/heads/master@{#392539}

Powered by Google App Engine
This is Rietveld 408576698