Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1960323002: MD Settings: Use shared cr_elements iconset when possible (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, extensions-reviews_chromium.org, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@CrIconsCrOS
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Use shared cr_elements iconset when possible This is the first step in getting Settings off of iron-icons. Changes any instances of icons already in the 'cr' iconset to use that iconset. A follow-up will consolidate the rest of the Settings icons inside a custom Settings iconset. R=dbeam@chromium.org BUG=605821 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d Cr-Commit-Position: refs/heads/master@{#392599}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -37 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/internet_detail_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_proxy_exclusions.html View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/edit_dictionary_page.html View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/languages_page.html View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/manage_languages_page.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/on_startup_page/startup_url_entry.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/people_page/user_list.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/reset_page/reset_profile_banner.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.html View 1 2 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/resources/settings/settings_dialog.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/languages_page_browsertest.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/icons.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
michaelpg
Dan, PTAL. It's a pretty boring change. I'll send the next one to stevenjb.
4 years, 7 months ago (2016-05-09 19:40:47 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/1960323002/diff/1/chrome/browser/resources/settings/settings_shared_css.html File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/1960323002/diff/1/chrome/browser/resources/settings/settings_shared_css.html#newcode54 chrome/browser/resources/settings/settings_shared_css.html:54: iron-icon[icon=done] { "i wish i had a 'cr:'!" ...
4 years, 7 months ago (2016-05-09 19:54:05 UTC) #3
michaelpg
https://codereview.chromium.org/1960323002/diff/1/chrome/browser/resources/settings/settings_shared_css.html File chrome/browser/resources/settings/settings_shared_css.html (right): https://codereview.chromium.org/1960323002/diff/1/chrome/browser/resources/settings/settings_shared_css.html#newcode54 chrome/browser/resources/settings/settings_shared_css.html:54: iron-icon[icon=done] { On 2016/05/09 19:54:05, Dan Beam wrote: > ...
4 years, 7 months ago (2016-05-09 20:53:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960323002/20001
4 years, 7 months ago (2016-05-10 04:35:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1960323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1960323002/20001
4 years, 7 months ago (2016-05-10 14:33:31 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 14:37:41 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 14:40:13 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf2d0f7b9eeeab5618f0656e81d40aa5d736557d
Cr-Commit-Position: refs/heads/master@{#392599}

Powered by Google App Engine
This is Rietveld 408576698