Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(968)

Issue 1957313002: Material WebUI: Switch to poly-icons to generate iconsets (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Material WebUI: Switch to poly-icons to generate iconsets This is a follow-up to https://codereview.chromium.org/1947533002/. Instead of copying iron-icon definitions from third_party/polymer, we generate them using https://poly-icon.appspot.com. This has the advantage of being easier to reproduce and update, as a single URL can generate the list of SVG <g> definitions neaded. The actual definitions are the same, but the comments were changed to reflect the new generation style. Also, the shared icon file is renamed to "icons.html" to reflect similar conventions in MD Extensions and (soon) MD settings, and the iconset prefix is simply "cr". BUG=605821 R=dbeam@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9 Cr-Commit-Position: refs/heads/master@{#392360}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M chrome/browser/resources/md_downloads/toolbar.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_subentry.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/search_engines_page/search_engine_entry.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_menu/settings_menu.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_ui/settings_ui.html View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/site_settings/site_list.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_expand_button/cr_expand_button.js View 1 1 chunk +1 line, -1 line 0 comments Download
D ui/webui/resources/cr_elements/cr_icons.html View 1 chunk +0 lines, -25 lines 0 comments Download
M ui/webui/resources/cr_elements/cr_search_field/cr_search_field.html View 3 chunks +3 lines, -3 lines 0 comments Download
A + ui/webui/resources/cr_elements/icons.html View 1 chunk +9 lines, -7 lines 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_indicator_behavior.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements_resources.grdp View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
michaelpg
PTAL at what we talked about.
4 years, 7 months ago (2016-05-09 13:49:49 UTC) #2
Dan Beam
lgtm
4 years, 7 months ago (2016-05-09 14:41:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957313002/20001
4 years, 7 months ago (2016-05-09 14:46:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/209172)
4 years, 7 months ago (2016-05-09 15:57:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1957313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1957313002/20001
4 years, 7 months ago (2016-05-09 17:30:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 18:01:26 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:02:40 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3bf153ec58660ee00f38d6d7d5a50418cb5c3aa9
Cr-Commit-Position: refs/heads/master@{#392360}

Powered by Google App Engine
This is Rietveld 408576698