Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Side by Side Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 1948633002: Add histograms for notices about other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Android Fix Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h" 5 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/metrics/histogram_macros.h" 10 #include "base/metrics/histogram_macros.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory( 192 browsing_data_ui::ShouldShowNoticeAboutOtherFormsOfBrowsingHistory(
193 sync_service_, 193 sync_service_,
194 WebHistoryServiceFactory::GetForProfile(Profile::FromWebUI(web_ui())), 194 WebHistoryServiceFactory::GetForProfile(Profile::FromWebUI(web_ui())),
195 base::Bind(&ClearBrowsingDataHandler::UpdateHistoryNotice, 195 base::Bind(&ClearBrowsingDataHandler::UpdateHistoryNotice,
196 weak_ptr_factory_.GetWeakPtr())); 196 weak_ptr_factory_.GetWeakPtr()));
197 } 197 }
198 198
199 void ClearBrowsingDataHandler::UpdateHistoryNotice(bool show) { 199 void ClearBrowsingDataHandler::UpdateHistoryNotice(bool show) {
200 should_show_history_footer_ = show; 200 should_show_history_footer_ = show;
201 OnStateChanged(); 201 OnStateChanged();
202
203 UMA_HISTOGRAM_BOOLEAN(
204 "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated",
205 should_show_history_footer_);
202 } 206 }
203 207
204 } // namespace settings 208 } // namespace settings
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698