chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc - Issue 1948633002: Add histograms for notices about other forms of browsing history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 1948633002: Add histograms for notices about other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android Fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.cc ('k') | ios/chrome/browser/ui/webui/history/browsing_history_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

index 6309acec1cb5e92a457d2e1c749956dd56407ccb..638c0fda7361115379b00e9fd174aee64203d8f9 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

@@ -199,6 +199,10 @@ void ClearBrowsingDataHandler::RefreshHistoryNotice() {

void ClearBrowsingDataHandler::UpdateHistoryNotice(bool show) {

should_show_history_footer_ = show;

OnStateChanged();

+ UMA_HISTOGRAM_BOOLEAN(

+ "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated",

+ should_show_history_footer_);

}

} // namespace settings