chrome/browser/android/preferences/pref_service_bridge.cc - Issue 1948633002: Add histograms for notices about other forms of browsing history

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 1948633002: Add histograms for notices about other forms of browsing history (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Android Fix Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java ('k') | chrome/browser/ui/webui/browsing_history_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/preferences/pref_service_bridge.cc

diff --git a/chrome/browser/android/preferences/pref_service_bridge.cc b/chrome/browser/android/preferences/pref_service_bridge.cc

index f0303b285251913573c9ced37bcc6681556c1bfb..87055b0371e5d91a27e787d3d0b77a7c4259971b 100644

--- a/chrome/browser/android/preferences/pref_service_bridge.cc

+++ b/chrome/browser/android/preferences/pref_service_bridge.cc

@@ -17,6 +17,7 @@

#include "base/android/jni_weak_ref.h"

#include "base/files/file_path.h"

#include "base/files/file_util.h"

+#include "base/metrics/histogram_macros.h"

#include "base/scoped_observer.h"

#include "base/strings/string_util.h"

#include "base/values.h"

@@ -645,6 +646,8 @@ static void ShowNoticeAboutOtherFormsOfBrowsingHistory(

ScopedJavaGlobalRef<jobject>* listener,

bool show) {

JNIEnv* env = AttachCurrentThread();

+ UMA_HISTOGRAM_BOOLEAN(

+ "History.ClearBrowsingData.HistoryNoticeShownInFooterWhenUpdated", show);

if (!show)

return;

Java_OtherFormsOfBrowsingHistoryListener_showNoticeAboutOtherFormsOfBrowsingHistory(