[DevTools] Runtime.getProperties on proxy object doesn't call traps

[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties for proxy objects.
Added a test.

BUG=581495
R=pfeldman@chromium.org

Committed: https://crrev.com/f00e71eb761f55d65e770fcf3dec1c7a28c0ec3f
Cr-Commit-Position: refs/heads/master@{#391748}

[kozy, 2016-05-04 00:52:10]

Pavel, please take a look.

[kozy, 2016-05-04 01:05:52]

Description was changed from

==========
[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties.
Added a test.

BUG=581495
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties for proxy objects.
Added a test.

BUG=581495
R=pfeldman@chromium.org
==========

[pfeldman, 2016-05-04 23:01:48]

https://codereview.chromium.org/1948583003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1948583003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:455: if
(isSymbol(property))
Are changes in this file related to your change? Do you want to land them
separately?

https://codereview.chromium.org/1948583003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp
(right):

https://codereview.chromium.org/1948583003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp:268: if
(object->IsString()) {
We only use length to detect array, you should not need it for string.

[pfeldman, 2016-05-04 23:05:37]

lgtm

[kozy, 2016-05-04 23:22:21]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-05-04 23:22:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948583003/60001

[commit-bot: I haz the power, 2016-05-05 02:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 02:21:17]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kozy, 2016-05-05 02:47:04]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-05-05 02:47:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1948583003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1948583003/60001

[commit-bot: I haz the power, 2016-05-05 03:43:22]

Description was changed from

==========
[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties for proxy objects.
Added a test.

BUG=581495
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties for proxy objects.
Added a test.

BUG=581495
R=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-05-05 03:43:24]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-05 03:44:31]

Description was changed from

==========
[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties for proxy objects.
Added a test.

BUG=581495
R=pfeldman@chromium.org
==========

to

==========
[DevTools] Runtime.getProperties on proxy object doesn't call traps

Runtime.getProperties will return only internal properties for proxy objects.
Added a test.

BUG=581495
R=pfeldman@chromium.org

Committed: https://crrev.com/f00e71eb761f55d65e770fcf3dec1c7a28c0ec3f
Cr-Commit-Position: refs/heads/master@{#391748}
==========

[commit-bot: I haz the power, 2016-05-05 03:44:33]

Patchset 4 (id:??) landed as
https://crrev.com/f00e71eb761f55d65e770fcf3dec1c7a28c0ec3f
Cr-Commit-Position: refs/heads/master@{#391748}