[DevTools] Runtime.getProperties on proxy object doesn't call traps

third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8InjectedScriptHost.h"
 
 #include "platform/inspector_protocol/String16.h"
 #include "platform/v8_inspector/InjectedScriptNative.h"
 #include "platform/v8_inspector/V8Compat.h"
 #include "platform/v8_inspector/V8DebuggerImpl.h"
@@ skipping 27 matching lines @@
 
 } // namespace
 
 v8::Local<v8::Object> V8InjectedScriptHost::create(v8::Local<v8::Context> context, V8DebuggerImpl* debugger)
 {
     v8::Isolate* isolate = debugger->isolate();
     v8::Local<v8::Object> injectedScriptHost = v8::Object::New(isolate);
     v8::Local<v8::External> debuggerExternal = v8::External::New(isolate, debugger);
     setFunctionProperty(context, injectedScriptHost, "internalConstructorName", V8InjectedScriptHost::internalConstructorNameCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "formatAccessorsAsProperties", V8InjectedScriptHost::formatAccessorsAsProperties, debuggerExternal);
-    setFunctionProperty(context, injectedScriptHost, "isTypedArray", V8InjectedScriptHost::isTypedArrayCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "subtype", V8InjectedScriptHost::subtypeCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "collectionEntries", V8InjectedScriptHost::collectionEntriesCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "getInternalProperties", V8InjectedScriptHost::getInternalPropertiesCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "getEventListeners", V8InjectedScriptHost::getEventListenersCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "suppressWarningsAndCallFunction", V8InjectedScriptHost::suppressWarningsAndCallFunctionCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "setNonEnumProperty", V8InjectedScriptHost::setNonEnumPropertyCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "bind", V8InjectedScriptHost::bindCallback, debuggerExternal);
     setFunctionProperty(context, injectedScriptHost, "proxyTargetValue", V8InjectedScriptHost::proxyTargetValueCallback, debuggerExternal);
+    setFunctionProperty(context, injectedScriptHost, "ownPropertyNames", V8InjectedScriptHost::ownPropertyNamesCallback, debuggerExternal);
+    setFunctionProperty(context, injectedScriptHost, "prototype", V8InjectedScriptHost::prototypeCallback, debuggerExternal);
     return injectedScriptHost;
 }
 
 void V8InjectedScriptHost::internalConstructorNameCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1 || !info[0]->IsObject())
         return;
 
     v8::Local<v8::Object> object = info[0].As<v8::Object>();
     info.GetReturnValue().Set(object->GetConstructorName());
 }
 
 void V8InjectedScriptHost::formatAccessorsAsProperties(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1)
         return;
 
     info.GetReturnValue().Set(unwrapDebugger(info)->client()->formatAccessorsAsProperties(info[0]));
 }
 
-void V8InjectedScriptHost::isTypedArrayCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
-{
-    if (info.Length() < 1)
-        return;
-
-    info.GetReturnValue().Set(info[0]->IsTypedArray());
-}
-
 void V8InjectedScriptHost::subtypeCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 1)
         return;
 
     v8::Isolate* isolate = info.GetIsolate();
     v8::Local<v8::Value> value = info[0];
     if (value->IsArray() || value->IsTypedArray() || value->IsArgumentsObject()) {
         info.GetReturnValue().Set(toV8StringInternalized(isolate, "array"));
         return;
@@ skipping 168 matching lines @@
     if (info.Length() != 1 || !info[0]->IsProxy()) {
         ASSERT_NOT_REACHED();
         return;
     }
     v8::Local<v8::Object> target = info[0].As<v8::Proxy>();
     while (target->IsProxy())
         target = v8::Local<v8::Proxy>::Cast(target)->GetTarget();
     info.GetReturnValue().Set(target);
 }
 
+static uint32_t objectLength(v8::Local<v8::Object> object)
+{
+    if (object->IsString()) {

[pfeldman, 2016/05/04 23:01:48]

We only use length to detect array, you should not need it for string.

+        int length = object.As<v8::String>()->Length();
+        return length > 0 ? static_cast<uint32_t>(object.As<v8::String>()->Length()) : 0;
+    }
+    if (object->IsArray())
+        return object.As<v8::Array>()->Length();
+    if (object->IsTypedArray())
+        return object.As<v8::TypedArray>()->Length();
+    return 0;
+}
+
+void V8InjectedScriptHost::ownPropertyNamesCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    ASSERT(info.Length() > 0 && info[0]->IsObject());
+
+    v8::Isolate* isolate = info.GetIsolate();
+    v8::Local<v8::Context> context = isolate->GetCurrentContext();
+    info.GetReturnValue().Set(v8::Array::New(isolate));
+    v8::Local<v8::Object> object = info[0].As<v8::Object>();
+
+    if (object->IsProxy())
+        return;
+
+    size_t length = objectLength(object);
+    const int kMaxIndexPropertyCount = 9999;
+    if (length > kMaxIndexPropertyCount) {
+        v8::Local<v8::Array> indexes = v8::Array::New(isolate, kMaxIndexPropertyCount);
+        for (size_t i = 0; i < kMaxIndexPropertyCount; ++i) {
+            if (!indexes->Set(context, i, v8::Integer::NewFromUnsigned(isolate, i)).FromMaybe(false))
+                return;
+        }
+        info.GetReturnValue().Set(indexes);
+        return;
+    }
+
+    v8::PropertyFilter filters[] = {
+        static_cast<v8::PropertyFilter>(v8::PropertyFilter::ONLY_ENUMERABLE | v8::PropertyFilter::SKIP_SYMBOLS),
+        static_cast<v8::PropertyFilter>(v8::PropertyFilter::ALL_PROPERTIES | v8::PropertyFilter::SKIP_SYMBOLS),
+        v8::PropertyFilter::ALL_PROPERTIES
+    };
+
+    v8::Local<v8::Set> output = v8::Set::New(isolate);
+    for (size_t i = 0; i < WTF_ARRAY_LENGTH(filters); ++i) {
+        v8::Local<v8::Array> properties;
+        if (!object->GetOwnPropertyNames(context, filters[i]).ToLocal(&properties))
+            return;
+        for (size_t i = 0; i < properties->Length(); ++i) {
+            v8::Local<v8::Value> value;
+            if (!properties->Get(context, i).ToLocal(&value))
+                return;
+            if (!output->Add(context, value).ToLocal(&output))
+                return;
+        }
+    }
+    info.GetReturnValue().Set(output->AsArray());
+}
+
+void V8InjectedScriptHost::prototypeCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
+{
+    ASSERT(info.Length() > 0 && info[0]->IsObject());
+    info.GetReturnValue().Set(info[0].As<v8::Object>()->GetPrototype());
+}
+
 v8::Local<v8::Private> V8Debugger::scopeExtensionPrivate(v8::Isolate* isolate)
 {
     return v8::Private::ForApi(isolate, toV8StringInternalized(isolate, "V8Debugger#scopeExtension"));
 }
 
 bool V8Debugger::isRemoteObjectAPIMethod(const String16& name)
 {
     return name == "bindRemoteObject";
 }
 
 } // namespace blink