Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1952553002: [DevTools] Auto completion for proxy uses proxy target object (Closed)

Created:
4 years, 7 months ago by kozy
Modified:
4 years, 7 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@move-property-descriptors-to-native
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Auto completion for proxy uses proxy target object BUG=581495 R=pfeldman@chromium.org,lushnikov@chromium.org Committed: https://crrev.com/0675c5c090b7cb2c7749b3586694698eb9cbfc3d Cr-Commit-Position: refs/heads/master@{#391760}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 5

Patch Set 5 : #

Total comments: 4

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -19 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/console-cd-completions.html View 1 2 3 chunks +103 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/console-cd-completions-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 2 3 4 5 3 chunks +44 lines, -6 lines 0 comments Download

Depends on Patchset:

Issue 1948583003 Patch 60001

Messages

Total messages: 16 (6 generated)
kozy
please take a look
4 years, 7 months ago (2016-05-04 01:47:46 UTC) #1
lushnikov
https://codereview.chromium.org/1952553002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1952553002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode535 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:535: if (internalProperties) { lets use as much fast returns ...
4 years, 7 months ago (2016-05-04 19:27:21 UTC) #2
lushnikov
lgtm
4 years, 7 months ago (2016-05-04 19:27:32 UTC) #3
pfeldman
lgtm https://codereview.chromium.org/1952553002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1952553002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode535 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:535: if (internalProperties) { On 2016/05/04 19:27:21, lushnikov wrote: ...
4 years, 7 months ago (2016-05-04 22:45:08 UTC) #4
kozy
all done https://codereview.chromium.org/1952553002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1952553002/diff/60001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode535 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:535: if (internalProperties) { On 2016/05/04 19:27:21, lushnikov ...
4 years, 7 months ago (2016-05-05 00:51:08 UTC) #5
lushnikov
https://codereview.chromium.org/1952553002/diff/80001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1952553002/diff/80001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode538 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:538: object.getOwnProperties(extractTargetFromProperties); return object.getOwnPropertiesPromise() .then(findTarget) .then(extractTarget); https://codereview.chromium.org/1952553002/diff/80001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode547 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:547: internalProperties = ...
4 years, 7 months ago (2016-05-05 01:06:04 UTC) #6
kozy
All done! https://codereview.chromium.org/1952553002/diff/80001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right): https://codereview.chromium.org/1952553002/diff/80001/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js#newcode538 third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:538: object.getOwnProperties(extractTargetFromProperties); On 2016/05/05 01:06:03, lushnikov wrote: > ...
4 years, 7 months ago (2016-05-05 01:35:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1952553002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1952553002/120001
4 years, 7 months ago (2016-05-05 03:55:06 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 7 months ago (2016-05-05 05:06:06 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 05:07:30 UTC) #14
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/0675c5c090b7cb2c7749b3586694698eb9cbfc3d
Cr-Commit-Position: refs/heads/master@{#391760}

Powered by Google App Engine
This is Rietveld 408576698