third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h - Issue 1948583003: [DevTools] Runtime.getProperties on proxy object doesn't call traps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

Issue 1948583003: [DevTools] Runtime.getProperties on proxy object doesn't call traps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('K') | « third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('j') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

index 2694bac103f80722d27da2b8ad44c0a5e34595f6..d1d88f1fc32790b1acf22d8dbbb1d504bcb31858 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.h

@@ -25,7 +25,6 @@ public:

private:

static void internalConstructorNameCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void formatAccessorsAsProperties(const v8::FunctionCallbackInfo<v8::Value>&);

- static void isTypedArrayCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void subtypeCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void generatorObjectDetailsCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void collectionEntriesCallback(const v8::FunctionCallbackInfo<v8::Value>&);

@@ -36,6 +35,8 @@ private:

static void setFunctionVariableValueCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void bindCallback(const v8::FunctionCallbackInfo<v8::Value>&);

static void proxyTargetValueCallback(const v8::FunctionCallbackInfo<v8::Value>&);

+ static void ownPropertyNamesCallback(const v8::FunctionCallbackInfo<v8::Value>&);

+ static void prototypeCallback(const v8::FunctionCallbackInfo<v8::Value>&);

};

} // namespace blink