Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1541)

Issue 1948123002: Add PRIVATE flags to global symbols (Closed)

Created:
4 years, 7 months ago by msarett
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add PRIVATE flags to global symbols This was added in a previous patch. https://codereview.chromium.org/6246098/ It was dropped in the updated to 1.4.90, so we need to reapply it. This change adds the 'private_extern' flags (on Mac) or the 'hidden' flags (on Linux) to the all global symbols in libjpeg-turbo. BUG=608347 R=mark@chromium.org, noel@chromium.org Committed: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo/+/51655203fbc949e6423dcd13ce22fe30ab5b5ea2

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -114 lines) Patch
M README.chromium View 1 1 chunk +3 lines, -0 lines 0 comments Download
M simd/jccolext-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jccolext-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jccolext-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jccolor-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jccolor-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jccolor-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcgray-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcgray-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcgray-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcgryext-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcgryext-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jcgryext-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jchuff-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jchuff-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jcsample-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jcsample-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jcsample-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jdcolext-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdcolext-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdcolext-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdcolor-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdcolor-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdcolor-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdmerge-mmx.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdmerge-sse2.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdmerge-sse2-64.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jdmrgext-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jdmrgext-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jdmrgext-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jdsample-mmx.asm View 5 chunks +5 lines, -5 lines 0 comments Download
M simd/jdsample-sse2.asm View 5 chunks +5 lines, -5 lines 0 comments Download
M simd/jdsample-sse2-64.asm View 5 chunks +5 lines, -5 lines 0 comments Download
M simd/jfdctflt-3dn.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctflt-sse.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctflt-sse-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctfst-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctfst-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctfst-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctint-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctint-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jfdctint-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctflt-3dn.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctflt-sse.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctflt-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctflt-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctfst-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctfst-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctfst-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctint-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctint-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctint-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jidctred-mmx.asm View 3 chunks +3 lines, -3 lines 0 comments Download
M simd/jidctred-sse2.asm View 3 chunks +3 lines, -3 lines 0 comments Download
M simd/jidctred-sse2-64.asm View 3 chunks +3 lines, -3 lines 0 comments Download
M simd/jquant-3dn.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jquant-mmx.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jquant-sse.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jquantf-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jquantf-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jquanti-sse2.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jquanti-sse2-64.asm View 2 chunks +2 lines, -2 lines 0 comments Download
M simd/jsimdcpu.asm View 1 chunk +1 line, -1 line 0 comments Download
M simd/jsimdext.inc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
msarett
After this lands, we should be clear to roll DEPS.
4 years, 7 months ago (2016-05-04 19:05:49 UTC) #5
Mark Mentovai
LGTM
4 years, 7 months ago (2016-05-04 20:26:32 UTC) #6
Noel Gordon
LGTM - with nits. https://codereview.chromium.org/1948123002/diff/20001/README.chromium File README.chromium (right): https://codereview.chromium.org/1948123002/diff/20001/README.chromium#newcode33 README.chromium:33: all the global symbols in ...
4 years, 7 months ago (2016-05-05 00:36:24 UTC) #7
msarett
On 2016/05/05 00:36:24, noel gordon wrote: > LGTM - with nits. > > https://codereview.chromium.org/1948123002/diff/20001/README.chromium > ...
4 years, 7 months ago (2016-05-05 13:01:33 UTC) #8
Noel Gordon
4 years, 7 months ago (2016-05-05 14:35:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
51655203fbc949e6423dcd13ce22fe30ab5b5ea2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698