README.chromium - Issue 1948123002: Add PRIVATE flags to global symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: README.chromium

Issue 1948123002: Add PRIVATE flags to global symbols (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master

Patch Set: Response to comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: README.chromium

diff --git a/README.chromium b/README.chromium

index 2846aeddd71d2c81c9e1b59328d0860c14ca3b5f..66d50c959fffde48491dfa54de5189e1d25973d2 100644

--- a/README.chromium

+++ b/README.chromium

@@ -29,6 +29,9 @@ externally visible functions to chromium_* so that we can avoid conflicts that

arise when system libraries attempt to use our libjpeg. Also, we applied the

following changes which are not merged to upstream:

+* Added the 'private_extern' flags on Mac (or the 'hidden' flags on Linux) to

+ all the global symbols in '.asm' files to prevent making them external ones.

+ http://crbug.com/608347

* Fix libjpeg_turbo svn r64 libjpeg6b compat issue: make the fast path Huffman

decoder fallback to slow decoding if the Huffman decoding bit sentinel > 16,

this to match the exact behavior of jpeg_huff_decode().

« no previous file with comments | « no previous file | simd/jccolext-mmx.asm » ('j') | no next file with comments »