Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: simd/jquant-sse.asm

Issue 1948123002: Add PRIVATE flags to global symbols (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master
Patch Set: Response to comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « simd/jquant-mmx.asm ('k') | simd/jquantf-sse2.asm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 ; 1 ;
2 ; jquant.asm - sample data conversion and quantization (SSE & MMX) 2 ; jquant.asm - sample data conversion and quantization (SSE & MMX)
3 ; 3 ;
4 ; Copyright 2009 Pierre Ossman <ossman@cendio.se> for Cendio AB 4 ; Copyright 2009 Pierre Ossman <ossman@cendio.se> for Cendio AB
5 ; 5 ;
6 ; Based on 6 ; Based on
7 ; x86 SIMD extension for IJG JPEG library 7 ; x86 SIMD extension for IJG JPEG library
8 ; Copyright (C) 1999-2006, MIYASAKA Masaru. 8 ; Copyright (C) 1999-2006, MIYASAKA Masaru.
9 ; For conditions of distribution and use, see copyright notice in jsimdext.inc 9 ; For conditions of distribution and use, see copyright notice in jsimdext.inc
10 ; 10 ;
(...skipping 17 matching lines...) Expand all
28 ; GLOBAL(void) 28 ; GLOBAL(void)
29 ; jsimd_convsamp_float_sse (JSAMPARRAY sample_data, JDIMENSION start_col, 29 ; jsimd_convsamp_float_sse (JSAMPARRAY sample_data, JDIMENSION start_col,
30 ; FAST_FLOAT *workspace); 30 ; FAST_FLOAT *workspace);
31 ; 31 ;
32 32
33 %define sample_data ebp+8 ; JSAMPARRAY sample_data 33 %define sample_data ebp+8 ; JSAMPARRAY sample_data
34 %define start_col ebp+12 ; JDIMENSION start_col 34 %define start_col ebp+12 ; JDIMENSION start_col
35 %define workspace ebp+16 ; FAST_FLOAT *workspace 35 %define workspace ebp+16 ; FAST_FLOAT *workspace
36 36
37 align 16 37 align 16
38 global EXTN(jsimd_convsamp_float_sse) 38 global EXTN(jsimd_convsamp_float_sse) PRIVATE
39 39
40 EXTN(jsimd_convsamp_float_sse): 40 EXTN(jsimd_convsamp_float_sse):
41 push ebp 41 push ebp
42 mov ebp,esp 42 mov ebp,esp
43 push ebx 43 push ebx
44 ; push ecx ; need not be preserved 44 ; push ecx ; need not be preserved
45 ; push edx ; need not be preserved 45 ; push edx ; need not be preserved
46 push esi 46 push esi
47 push edi 47 push edi
48 48
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 ; GLOBAL(void) 131 ; GLOBAL(void)
132 ; jsimd_quantize_float_sse (JCOEFPTR coef_block, FAST_FLOAT *divisors, 132 ; jsimd_quantize_float_sse (JCOEFPTR coef_block, FAST_FLOAT *divisors,
133 ; FAST_FLOAT *workspace); 133 ; FAST_FLOAT *workspace);
134 ; 134 ;
135 135
136 %define coef_block ebp+8 ; JCOEFPTR coef_block 136 %define coef_block ebp+8 ; JCOEFPTR coef_block
137 %define divisors ebp+12 ; FAST_FLOAT *divisors 137 %define divisors ebp+12 ; FAST_FLOAT *divisors
138 %define workspace ebp+16 ; FAST_FLOAT *workspace 138 %define workspace ebp+16 ; FAST_FLOAT *workspace
139 139
140 align 16 140 align 16
141 global EXTN(jsimd_quantize_float_sse) 141 global EXTN(jsimd_quantize_float_sse) PRIVATE
142 142
143 EXTN(jsimd_quantize_float_sse): 143 EXTN(jsimd_quantize_float_sse):
144 push ebp 144 push ebp
145 mov ebp,esp 145 mov ebp,esp
146 ; push ebx ; unused 146 ; push ebx ; unused
147 ; push ecx ; unused 147 ; push ecx ; unused
148 ; push edx ; need not be preserved 148 ; push edx ; need not be preserved
149 push esi 149 push esi
150 push edi 150 push edi
151 151
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 pop esi 202 pop esi
203 ; pop edx ; need not be preserved 203 ; pop edx ; need not be preserved
204 ; pop ecx ; unused 204 ; pop ecx ; unused
205 ; pop ebx ; unused 205 ; pop ebx ; unused
206 pop ebp 206 pop ebp
207 ret 207 ret
208 208
209 ; For some reason, the OS X linker does not honor the request to align the 209 ; For some reason, the OS X linker does not honor the request to align the
210 ; segment unless we do this. 210 ; segment unless we do this.
211 align 16 211 align 16
OLDNEW
« no previous file with comments | « simd/jquant-mmx.asm ('k') | simd/jquantf-sse2.asm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698