Chromium Code Reviews Chromium Code Reviews
Issue 1948123002:
Add PRIVATE flags to global symbols (Closed)
Base URL: https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git@master| OLD | NEW |
|---|---|
| 1 Name: libjpeg-turbo | 1 Name: libjpeg-turbo |
| 2 URL: https://github.com/libjpeg-turbo/libjpeg-turbo/ | 2 URL: https://github.com/libjpeg-turbo/libjpeg-turbo/ |
| 3 Version: 1.4.90 | 3 Version: 1.4.90 |
| 4 License: Custom license | 4 License: Custom license |
| 5 License File: LICENSE.md | 5 License File: LICENSE.md |
| 6 Security Critical: yes | 6 Security Critical: yes |
| 7 License Android Compatible: yes | 7 License Android Compatible: yes |
| 8 | 8 |
| 9 Description: | 9 Description: |
| 10 This consists of the components: | 10 This consists of the components: |
| (...skipping 11 matching lines...) Expand all Loading... | |
| 22 | 22 |
| 23 This libjpeg-turbo can replace our libjpeg-6b without any modifications in the | 23 This libjpeg-turbo can replace our libjpeg-6b without any modifications in the |
| 24 Chromium code. | 24 Chromium code. |
| 25 | 25 |
| 26 Same as our copy of libjpeg-6b, this libjpeg-turbo also added a new file | 26 Same as our copy of libjpeg-6b, this libjpeg-turbo also added a new file |
| 27 jpeglibmangler.h and included it from jpeglib.h that changes the names of all | 27 jpeglibmangler.h and included it from jpeglib.h that changes the names of all |
| 28 externally visible functions to chromium_* so that we can avoid conflicts that | 28 externally visible functions to chromium_* so that we can avoid conflicts that |
| 29 arise when system libraries attempt to use our libjpeg. Also, we applied the | 29 arise when system libraries attempt to use our libjpeg. Also, we applied the |
| 30 following changes which are not merged to upstream: | 30 following changes which are not merged to upstream: |
| 31 | 31 |
| 32 * Added the 'private_extern' flags on Mac (or the 'hidden' flags on Linux) to | |
| 33 all the global symbols in '.asm' files to prevent making them external ones. | |
|
Noel Gordon
2016/05/05 00:36:24
Add "http://crbug.com/608347" here.
| |
| 32 * Fix libjpeg_turbo svn r64 libjpeg6b compat issue: make the fast path Huffman | 34 * Fix libjpeg_turbo svn r64 libjpeg6b compat issue: make the fast path Huffman |
| 33 decoder fallback to slow decoding if the Huffman decoding bit sentinel > 16, | 35 decoder fallback to slow decoding if the Huffman decoding bit sentinel > 16, |
| 34 this to match the exact behavior of jpeg_huff_decode(). | 36 this to match the exact behavior of jpeg_huff_decode(). |
| 35 http://crbug.com/398235 | 37 http://crbug.com/398235 |
| 36 * Fixed an issue with the ARM NEON build. | 38 * Fixed an issue with the ARM NEON build. |
| 37 http://crbug.com/451035 | 39 http://crbug.com/451035 |
| 38 | 40 |
| 39 Refer to working-with-nested-repos [1] for details of how to setup your git | 41 Refer to working-with-nested-repos [1] for details of how to setup your git |
| 40 svn client to update the code (for making local changes, cherry picking from | 42 svn client to update the code (for making local changes, cherry picking from |
| 41 upstream, etc). | 43 upstream, etc). |
| 42 | 44 |
| 43 [1] https://www.chromium.org/developers/how-tos/get-the-code/working-with-nested -repos | 45 [1] https://www.chromium.org/developers/how-tos/get-the-code/working-with-nested -repos |
| OLD | NEW |
