Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1947083003: EDK: Replace HandleTable::GetDispatcher() with GetHandle(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work788_edk_handle_13.2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Replace HandleTable::GetDispatcher() with GetHandle(). Leave Core::GetDispatcher() "as-is" (functionally), since I want to replace it with something that gets a dispatcher and *checks* rights (instead of just having everyone call GetHandle() and checking rights themselves). R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bb342af193f226c0214c12fb5889d1ff850922d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -40 lines) Patch
M mojo/edk/system/core.h View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/edk/system/core.cc View 3 chunks +18 lines, -13 lines 0 comments Download
M mojo/edk/system/handle_table.h View 1 chunk +6 lines, -7 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/edk/system/handle_table_unittest.cc View 2 chunks +10 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
(Depends on https://codereview.chromium.org/1946423002/.)
4 years, 7 months ago (2016-05-04 21:49:55 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-04 23:09:58 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-05 16:15:04 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bb342af193f226c0214c12fb5889d1ff850922d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698