Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1905)

Unified Diff: mojo/edk/system/handle_table.h

Issue 1947083003: EDK: Replace HandleTable::GetDispatcher() with GetHandle(). (Closed) Base URL: https://github.com/domokit/mojo.git@work788_edk_handle_13.2
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/system/core.cc ('k') | mojo/edk/system/handle_table.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/handle_table.h
diff --git a/mojo/edk/system/handle_table.h b/mojo/edk/system/handle_table.h
index 4cdbd36ed4e1194141cfdc2063a9c1558b10e8f5..fb346d6193b68f250e848d1b21cf71dacced10fe 100644
--- a/mojo/edk/system/handle_table.h
+++ b/mojo/edk/system/handle_table.h
@@ -49,13 +49,12 @@ class HandleTable {
// convenient for there to be a "GetDispatcher()" that automatically does
// rights-checking.)
- // On success, gets the dispatcher for a given handle value (which should not
- // be |MOJO_HANDLE_INVALID|). On failure, returns an appropriate result (and
- // leaves |dispatcher| alone), namely |MOJO_RESULT_INVALID_ARGUMENT| if
- // there's no dispatcher for the given handle value or |MOJO_RESULT_BUSY| if
- // the handle value is marked as busy.
- MojoResult GetDispatcher(MojoHandle handle_value,
- util::RefPtr<Dispatcher>* dispatcher);
+ // On success, gets the handle for the given handle value (which should not be
+ // |MOJO_HANDLE_INVALID|). On failure, returns an appropriate result (and
+ // leaves |*handle| alone), namely |MOJO_RESULT_INVALID_ARGUMENT| if there's
+ // no handle for the given handle value or |MOJO_RESULT_BUSY| if the handle is
+ // marked as busy.
+ MojoResult GetHandle(MojoHandle handle_value, Handle* handle);
// Like |GetDispatcher()|, but on success also removes the handle value from
// the handle table.
« no previous file with comments | « mojo/edk/system/core.cc ('k') | mojo/edk/system/handle_table.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698