Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949283002: EDK: Replace HandleTable::GetAndRemoveDispatcher() with GetAndRemoveHandle(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work789_edk_handle_13.3-x-work788_edk_handle_13.2
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Replace HandleTable::GetAndRemoveDispatcher() with GetAndRemoveHandle(). (Also temporarily leave in Core::GetAndRemoveDispatcher() for now, though it should probably be replaced with a GetAndRemoveHandle() directly.) R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/74ccfefafca42b5208548d1a58750a65705ccd40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -148 lines) Patch
M mojo/edk/system/core.h View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/edk/system/core.cc View 3 chunks +15 lines, -12 lines 0 comments Download
M mojo/edk/system/handle.h View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/edk/system/handle_table.h View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/edk/system/handle_table.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/edk/system/handle_table_unittest.cc View 4 chunks +127 lines, -125 lines 0 comments Download

Depends on Patchset:

Issue 1947083003 Patch 1

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-04 23:17:10 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-04 23:28:25 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-05 16:16:12 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
74ccfefafca42b5208548d1a58750a65705ccd40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698