Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1946423002: EDK: Remove Core::AddDispatcher(). (Closed)

Created:
4 years, 7 months ago by viettrungluu
Modified:
4 years, 7 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Remove Core::AddDispatcher(). Use AddHandle() instead. Also, add kDefaultHandleRights static member variables to the various dispatcher implementations. (Arguably, their Create() static factories should produce a Handle instead, and thus automatically have the default handle rights.) R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c1ffb9f8dcdb9e61590224740e7f2f3a16ea1744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -118 lines) Patch
M mojo/edk/embedder/embedder.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/edk/embedder/multiprocess_embedder.cc View 5 chunks +13 lines, -8 lines 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 2 chunks +6 lines, -1 line 0 comments Download
M mojo/edk/system/core.h View 1 chunk +0 lines, -6 lines 0 comments Download
M mojo/edk/system/core.cc View 5 chunks +11 lines, -21 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 3 chunks +7 lines, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 6 chunks +12 lines, -18 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/ipc_support_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/multiprocess_message_pipe_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/edk/system/platform_handle_dispatcher_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 24 chunks +64 lines, -40 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 2 chunks +8 lines, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 7 months ago (2016-05-04 20:26:14 UTC) #1
azani
lgtm
4 years, 7 months ago (2016-05-04 23:07:19 UTC) #2
viettrungluu
4 years, 7 months ago (2016-05-05 16:14:17 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c1ffb9f8dcdb9e61590224740e7f2f3a16ea1744 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698