Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1945023004: [Cronet] run pylint in Cronet presubmit check (Closed)

Created:
4 years, 7 months ago by pauljensen
Modified:
4 years, 7 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] run pylint in Cronet presubmit check This should help avoid breakages from telemetry changes. Many specific checks are disabled but at least general correctness should be maintained. Committed: https://crrev.com/6a6e783c84665d5784374677f6e6a8add5c24a5e Cr-Commit-Position: refs/heads/master@{#391808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -12 lines) Patch
M components/cronet/PRESUBMIT.py View 1 chunk +28 lines, -1 line 0 comments Download
M components/cronet/android/test/javaperftests/android_rndis_forwarder.py View 3 chunks +5 lines, -2 lines 0 comments Download
M components/cronet/android/test/javaperftests/run.py View 3 chunks +5 lines, -3 lines 0 comments Download
A + components/cronet/pylintrc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/tools/cr_cronet.py View 1 chunk +2 lines, -1 line 0 comments Download
M components/cronet/tools/extract_from_jars.py View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/tools/generate_javadoc.py View 1 chunk +0 lines, -1 line 0 comments Download
M components/cronet/tools/jar_src.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pauljensen
Misha, PTAL.
4 years, 7 months ago (2016-05-04 11:48:13 UTC) #2
mef
lgtm Should we file a bug to shrink the list of disabled lints?
4 years, 7 months ago (2016-05-05 14:55:29 UTC) #3
pauljensen
On 2016/05/05 14:55:29, mef wrote: > lgtm > > Should we file a bug to ...
4 years, 7 months ago (2016-05-05 15:04:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1945023004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1945023004/1
4 years, 7 months ago (2016-05-05 15:05:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 15:43:13 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 15:44:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a6e783c84665d5784374677f6e6a8add5c24a5e
Cr-Commit-Position: refs/heads/master@{#391808}

Powered by Google App Engine
This is Rietveld 408576698