Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: components/cronet/android/test/javaperftests/android_rndis_forwarder.py

Issue 1945023004: [Cronet] run pylint in Cronet presubmit check (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/PRESUBMIT.py ('k') | components/cronet/android/test/javaperftests/run.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javaperftests/android_rndis_forwarder.py
diff --git a/components/cronet/android/test/javaperftests/android_rndis_forwarder.py b/components/cronet/android/test/javaperftests/android_rndis_forwarder.py
index bec2ab14b05d7f468086ecef0e0cf7bca02fc254..a8c17200500d4dd52a47837767fb1bd29d1e229b 100644
--- a/components/cronet/android/test/javaperftests/android_rndis_forwarder.py
+++ b/components/cronet/android/test/javaperftests/android_rndis_forwarder.py
@@ -3,6 +3,7 @@
# found in the LICENSE file.
import atexit
+import logging
import os
import re
import socket
@@ -10,7 +11,9 @@ import struct
import subprocess
from telemetry.core import platform
+from telemetry.core import util
from telemetry.internal.platform import android_device
+from telemetry.internal.util import binary_manager
from devil.android import device_errors
from devil.android import device_utils
@@ -413,8 +416,8 @@ doit &
'The IP address configuration %s of %s is not unique!\n'
'Check your /etc/network/interfaces. If this overlap is intended,\n'
'you might need to use: ip rule add from <device_ip> lookup <table>\n'
- 'or add the interface to a bridge in order to route to this network.'
- % (host_address, host_iface)
+ 'or add the interface to a bridge in order to route to this network.',
+ host_address, host_iface
)
# Find unused IP address.
« no previous file with comments | « components/cronet/PRESUBMIT.py ('k') | components/cronet/android/test/javaperftests/run.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698